Open Bug 1207114 Opened 4 years ago Updated 3 years ago

the default action button in the directory picker shown by <input type=file directory> should be labelled "Choose" rather than "Open"

Categories

(Core :: Widget: Cocoa, defect, P4)

Unspecified
macOS
defect

Tracking

()

People

(Reporter: jfkthame, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: tpi:+)

When clicking the "Choose folder" button in <input type=file directory>, the default button at the bottom right of the picker is labelled "Open".

However, clicking it (or pressing Enter) does not "open" the selected folder in the list (as does double-clicking a folder name) to show its contents; instead, it "chooses" the selected folder and dismisses the picker.

Accordingly, the button should be labelled "Choose" (or "Select", or something... fwiw, the corresponding button on Win8 is labelled "Select Folder").
Hmm, this is a native picker, so I'm not sure we have control over that. I'll have to check. Besides though, the position of the button in the dialog next to the Cancel button would I think make it clear to the user that they are making their selection. And in a sense I think "Open" is a better name than "Choose", since it gives the use a better idea of the fact that the page then has access to read the contents of the directory.
Component: Layout: Form Controls → Widget: Cocoa
(I'd also note that in Upuntu 14.04 it's also "Open")
Thanks, Markus, good to know it's possible.

It's still not clear to me that this change would be desirable.
I wonder if it might make more sense to label this button "Upload", since, while not technically what the user is doing at that point, it makes clearer to the user that this is a natural consequence of their action and should be considered as such.
I instinctively suggested "Choose" because I thought I remembered seeing that in directory pickers when used by other apps on OS X. But I'm not sure where I was remembering it from.....

With a bit of poking around, I found dir pickers in Xcode, and yes, those do label the button "Choose". But in Safari (when choosing a location for downloads), it's "Select". And when selecting folders in TextWrangler's Find Differences dialog, it's simply "Open".

"Upload" seems wrong to me, given that the page may not be intending to upload the directory contents at all; e.g. it might be intending to iterate over the contents and do something purely locally with them.

So I guess the "right" answer here isn't as clear-cut as I initially imagined.
Blocks: 1203487
Whiteboard: tpi:3
Priority: -- → P4
Whiteboard: tpi:3 → tpi:+
You need to log in before you can comment on or make changes to this bug.