Closed Bug 1207178 Opened 10 years ago Closed 10 years ago

Test status message displays 'AssertionError: Traceback (most recent call last):' instead of reason for failure

Categories

(Testing Graveyard :: external-media-tests, defect)

Product:
Testing Graveyard
Component:
external-media-tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: impossibus, Assigned: impossibus)

References

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mjzffr/firefox-media-tests/pull/22
53 bytes, text/x-github-pull-request
sydpolk
: review+
Details | Review
Example: > TEST-UNEXPECTED-ERROR | test_basic_playback.py > TestBasicYouTubePlayback.test_video_playing_in_one_tab | AssertionError: > Traceback (most recent call last):
I believe the problem is in |verbose_until|. Here's an example of how the message is changed by the attached PR. If the condition used is a function called 'playback_done': > TEST-UNEXPECTED-FAIL | test_basic_playback.py > TestBasicYouTubePlayback.test_video_playing_in_one_tab | AssertionError: > TimeoutException: Timed out after 3.0 seconds; condition: playback_done Or if the condition used is a lambda: > TEST-UNEXPECTED-ERROR | test_basic_playback.py > TestBasicYouTubePlayback.test_video_playing_in_one_tab | AssertionError: > TimeoutException: Timed out after 3.0 seconds; condition: <lambda>
Attachment #8664252 - Flags: review?(spolk)
Comment on attachment 8664252 [details] [review] Link to Github pull-request: https://github.com/mjzffr/firefox-media-tests/pull/22 Looks good.
Attachment #8664252 - Flags: review?(spolk) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: