1207266 - Cannot compile Gecko with --disable-b2g-ril

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Ronald Claveau [:sousmangoosta]]

Have this error with the compilation failed:

22:11:27     INFO -  In file included from /home/worker/workspace/B2G/objdir-gecko/dom/system/gonk/Unified_cpp_dom_system_gonk1.cpp:38:0:
22:11:27     INFO -  /home/worker/workspace/gecko/dom/system/gonk/mozstumbler/MozStumbler.cpp:23:36: fatal error: nsIRadioInterfaceLayer.h: No such file or directory
22:11:27     INFO -  compilation terminated.
22:11:27    ERROR -  make[6]: *** [Unified_cpp_dom_system_gonk1.o] Error 1
22:11:27     INFO -  make[6]: Leaving directory `/home/worker/workspace/B2G/objdir-gecko/dom/system/gonk'
22:11:27    ERROR -  make[5]: *** [dom/system/gonk/target] Error 2

there is no "#ifdef MOZ_B2G_RIL" surrounding the inclusion of the headers :

#include "nsIInterfaceRequestor.h"
#include "nsIInterfaceRequestorUtils.h"
#include "nsIMobileConnectionInfo.h"
#include "nsIMobileConnectionService.h"
#include "nsIMobileCellInfo.h"
#include "nsIMobileNetworkInfo.h"
#include "nsINetworkInterface.h"
#include "nsIRadioInterfaceLayer.h"

in file dom/system/gonk/mozstumbler/MozStumbler.cpp

Comment 1

[:garvan]

Needs 
-the moz.build changed, the mozstumbler code should only be compiled if there is a RIL, 
- and the call to mozstumbler in gonkgps*.cpp needs to be wrapped in ifdef for b2g RIL

Comment 2

[:garvan]

Attachment: disable compilation of b2g stumbler if no RIL

Try is green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a9ab6e039da

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d05dd7bd1404

Comment 4

[:garvan]

Thanks for the review Josh. 

Ronald, if you have a chance can you try this patch and comment if the tablet compilation is ok now? Or, at least ok in regards to the mozstumbler code errors.

Comment 5

[Ronald Claveau [:sousmangoosta]]

Sure Garvan, I launched a try with your patch here : https://treeherder.mozilla.org/#/jobs?repo=try&revision=2613cebacfc8

Comment 6

[:garvan]

Thanks, and TIL about try with 'aries-noril'!

Comment 7

[Ronald Claveau [:sousmangoosta]]

The build is ok on try with your patch, looks good to me.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d05dd7bd1404