Closed Bug 1207266 Opened 4 years ago Closed 4 years ago

Cannot compile Gecko with --disable-b2g-ril

Categories

(Core :: DOM: Geolocation, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: sousmangoosta, Assigned: sousmangoosta)

Details

Attachments

(1 file)

Have this error with the compilation failed:

22:11:27     INFO -  In file included from /home/worker/workspace/B2G/objdir-gecko/dom/system/gonk/Unified_cpp_dom_system_gonk1.cpp:38:0:
22:11:27     INFO -  /home/worker/workspace/gecko/dom/system/gonk/mozstumbler/MozStumbler.cpp:23:36: fatal error: nsIRadioInterfaceLayer.h: No such file or directory
22:11:27     INFO -  compilation terminated.
22:11:27    ERROR -  make[6]: *** [Unified_cpp_dom_system_gonk1.o] Error 1
22:11:27     INFO -  make[6]: Leaving directory `/home/worker/workspace/B2G/objdir-gecko/dom/system/gonk'
22:11:27    ERROR -  make[5]: *** [dom/system/gonk/target] Error 2

there is no "#ifdef MOZ_B2G_RIL" surrounding the inclusion of the headers :

#include "nsIInterfaceRequestor.h"
#include "nsIInterfaceRequestorUtils.h"
#include "nsIMobileConnectionInfo.h"
#include "nsIMobileConnectionService.h"
#include "nsIMobileCellInfo.h"
#include "nsIMobileNetworkInfo.h"
#include "nsINetworkInterface.h"
#include "nsIRadioInterfaceLayer.h"

in file dom/system/gonk/mozstumbler/MozStumbler.cpp
Needs 
-the moz.build changed, the mozstumbler code should only be compiled if there is a RIL, 
- and the call to mozstumbler in gonkgps*.cpp needs to be wrapped in ifdef for b2g RIL
Attachment #8665072 - Flags: review?(josh) → review+
Thanks for the review Josh. 

Ronald, if you have a chance can you try this patch and comment if the tablet compilation is ok now? Or, at least ok in regards to the mozstumbler code errors.
Sure Garvan, I launched a try with your patch here : https://treeherder.mozilla.org/#/jobs?repo=try&revision=2613cebacfc8
Thanks, and TIL about try with 'aries-noril'!
The build is ok on try with your patch, looks good to me.
Assignee: nobody → sousmangoosta
https://hg.mozilla.org/mozilla-central/rev/d05dd7bd1404
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.