1207278 - Add top level load flag into nsILoadInfo

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

It shoiuld be possible to figure out - from the parent process - whether given nsIRequest represents top level load. The info should be accessible through the associated nsILoadInfo structure.

This is required by JSON Response Viewer developer tools, see also:
https://bugzilla.mozilla.org/show_bug.cgi?id=1132203#c163

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Any, progress on this?

It's blocking the JSON Response Viewer bug that has high
priority for DevTools team.

Honza

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I looked into this today and maybe we don't need anything new. nsILoadInfo includes both outerWindowID and parentOuterWindowID. If it's a top-level window, parentOuterWindowID == otherWindowID. Otherwise they'll be different. Can you just check that?

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Bill McCloskey (:billm) from comment #2)
> I looked into this today and maybe we don't need anything new. nsILoadInfo
> includes both outerWindowID and parentOuterWindowID. If it's a top-level
> window, parentOuterWindowID == otherWindowID. Otherwise they'll be
> different. Can you just check that?
Excellent, seems to be working. I've attached a new patch to the bug 1132203 and I am waiting for review from :bz. If all passes (including tests) I'll close this one.

Thanks!
Honza

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

This looks indeed fixed in bug 1132203, but please reopen if I am mistaken.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Ah, yes, forgot to close this one, thanks Panos.

Honza