1207309 - Disable '<' add test button if adjacent container empty

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P5)

Description

[Jonathan French (:jfrench)]

If I understand the functionality correctly, it might be nice if the < chevron-left button was disabled if/until there are contents in the adjacent right side 'Tests to add' container.

When that container is empty, it appears that button doesn't have any function.

To reproduce:
o https://treeherder.mozilla.org/perf.html#/graphs?timerange=604800
o click on the blue 'Add test data'
o click on a test eg. tp4m, etc
o click on the < button

The same could perhaps also be said for both < and > buttons until an initial test is selected.

This may also prevent some console errors it hit when exploring that behavior. For example if you add a test to add to the right hand container, click '<' to remove it, and then click '<' again, you will get a Error: test is undefined in the console.

Comment 1

[Jonathan French (:jfrench)]

Attachment: chevronLeft

Per screen grab.

Comment 2

[MikeLing]

Attachment: PR for bug 1207309

Comment 3

[Jonathan French (:jfrench)]

Comment on attachment 8664576 [details] [review]
PR for bug 1207309

r+ with whatever other tweaks you and :wlach may like to make :)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c4a067ef99500c84e741a2bf02a0514663fb6b29
Bug 1207309 - Disable '<' add test button if adjacent container empty

Comment 5

[William Lachance (:wlach)]

Sorry I missed this earlier. Looks good, merged! Thanks.