Closed Bug 1207309 Opened 5 years ago Closed 5 years ago

Disable '<' add test button if adjacent container empty

Categories

(Tree Management :: Perfherder, defect, P5, minor)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jfrench, Assigned: sabergeass)

Details

Attachments

(2 files)

If I understand the functionality correctly, it might be nice if the < chevron-left button was disabled if/until there are contents in the adjacent right side 'Tests to add' container.

When that container is empty, it appears that button doesn't have any function.

To reproduce:
o https://treeherder.mozilla.org/perf.html#/graphs?timerange=604800
o click on the blue 'Add test data'
o click on a test eg. tp4m, etc
o click on the < button

The same could perhaps also be said for both < and > buttons until an initial test is selected.

This may also prevent some console errors it hit when exploring that behavior. For example if you add a test to add to the right hand container, click '<' to remove it, and then click '<' again, you will get a Error: test is undefined in the console.
Attached image chevronLeft
Per screen grab.
Attached file PR for bug 1207309
Attachment #8664576 - Flags: review?(tojonmz)
Assignee: nobody → sabergeass
Comment on attachment 8664576 [details] [review]
PR for bug 1207309

r+ with whatever other tweaks you and :wlach may like to make :)
Attachment #8664576 - Flags: review?(tojonmz) → review+
Sorry I missed this earlier. Looks good, merged! Thanks.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.