1207312 - ASan: SEGV at NULL in MozPromise

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Tyson Smith [:tsmith]]

Attachment: call_stack.txt

I came across this fuzzing a couple weeks ago but have been swamped and didn't log it. It appears to be preventing me from reproducing bug 1206211

Comment 1

[Tyson Smith [:tsmith]]

Attachment: test_case.mp4

Comment 2

[Jean-Yves Avenard [:jya]]

I encountered that same crash when playing with ffmpeg on mac ; likely the same.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: P1. Prevent crash when more than one promise is rejected.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: P2. Amend gtest.

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8667695 [details] [diff] [review]
P1. Prevent crash when more than one promise is rejected.

Review of attachment 8667695 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks.

Comment 6

[Bobby Holley (:bholley)]

Comment on attachment 8667696 [details] [diff] [review]
P2. Amend gtest.

Review of attachment 8667696 [details] [diff] [review]:
-----------------------------------------------------------------

Please add a comment describing what this test misses without a second rejection. :-)

Comment 7

[Bobby Holley (:bholley)]

Nice find, Tyson.

Comment 8

[Tyson Smith [:tsmith]]

(In reply to Bobby Holley (:bholley) from comment #7)
> Nice find, Tyson.

Thanks! Once this is in m-c I'll fire up that fuzzer again.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/47db8328de21
https://hg.mozilla.org/mozilla-central/rev/c3a9d50943f4