1207366 - Default sort columns restricted by backend code

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The backend restricts default sorting columns like this:

>  if (*aDefaultSortType < nsMsgViewSortType::byDate ||
>      *aDefaultSortType > nsMsgViewSortType::byAccount)
>    *aDefaultSortType = nsMsgViewSortType::byDate;
https://dxr.mozilla.org/comm-central/source/mailnews/db/msgdb/src/nsMsgDatabase.cpp#5635

Custom, Received and Correspondent have higher values than Account:
https://dxr.mozilla.org/comm-central/source/mailnews/base/public/nsIMsgDBView.idl#59

alta88, you recently worked on sorting of custom columns, do you of anything which would break or cause issues if we increase the upper limit to byCorrespondent?

Comment 1

[alta88]

that just looks to be a sanity check, written before the relatively recent received and correspondent, which were added after custom. the range can include up to correspondent but must exclude custom, which is meaningless without a column id (added by an extension).

Comment 2

[Wayne Mery (:wsmwk)]

Is this still an issue with the new 115 code?

Comment 3

[Geoff Lankow (:darktrojan)]

Sure is.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1207366 - Allow setting the default sort column to all useful values. r=#thunderbird-reviewers

This just updates the maximum allowed value for the preference, since new values have been added since it was written.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/be11e848f508
Allow setting the default sort column to all useful values. r=aleca