1207404 - Firstrun sync image is too small

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Sync vs Import

The sync image is too small - either the files are in the wrong dimen resource folders, or the images need to be bigger.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Using the Sync fragment in both

I wonder if there is something weird with the image? I can't figure out why the images would be different sizes, even though they look like the same size when I open them locally.

Antlam, any ideas on what could be different? I do notice that the devices/sync image is bigger in bytes than the coffee one in XXHDPI. This only affects tablets.

Comment 2

[Chenxia Liu [:liuche]]

Attachment: Screenshot: No large-xxhdpi image

Oh, because the obvious answer is that we have some extra images for the import panel on tablets, specifically drawable-large-xxhdpi. We either need to add another image for large-xxhdpi, or be okay with smaller images for tablets.

The actual solution is probably to ship a single very-large image and just scale the height per device type.

"import" resources:
http://mxr.mozilla.org/mozilla-central/find?string=coffee&tree=mozilla-central&hint=
"sync" resources:
http://mxr.mozilla.org/mozilla-central/find?string=_devices.png&tree=mozilla-central&hint=

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: tablet_img_slide2_XXHDPI.png

try this

Comment 4

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1207404 - First run image is too small. r=sebastian

Bug 1207404 - First run image is too small. r=sebastian

Comment 5

[Chenxia Liu [:liuche]]

I removed a bunch of images in the meantime, which cuts the apk size by some hundreds of KB.

I tested this on a N7 (tablet), N5, Nexus S, and a Asus Transformer and everything worked fine.

However, the Galaxy Nexus did not seem to be able to downscale from the xxhdpi resource I moved into drawable/ and didn't show the image at all until I reverted the hdpi files. I'll investigate more tomorrow, but the error was:

10-20 02:00:26.749  11774-11794/org.mozilla.fennec_liuche E/libEGL﹕ validate_display:257 error 3008 (EGL_BAD_DISPLAY)

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8675979 [details]
MozReview Request: Bug 1207404 - First run image is too small. r=sebastian

https://reviewboard.mozilla.org/r/22537/#review20075

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Chenxia Liu [:liuche] from comment #5)
> I removed a bunch of images in the meantime, which cuts the apk size by some
> hundreds of KB.

\o/


> However, the Galaxy Nexus did not seem to be able to downscale from the
> xxhdpi resource I moved into drawable/ and didn't show the image at all
> until I reverted the hdpi files.

What version of Android is the Galaxy Nexus running? Maybe back then the xxhdpi bucket wasn't added yet?

Comment 8

[Chenxia Liu [:liuche]]

I actually missed the relevant error, which popped up when I turned logging to verbose. The file in the drawable/ directory was getting scaled up too much to be used on the Galaxy Nexus, so it was complaining “Bitmap too large to be uploaded into a texture”.

"Android assumes drawables without a density qualifier are mdpi and scales them up or down for other densities, in this case scaled up 2x for xhdpi." [1] So when the image was already an xxhdpi image, scaling it up by 2x or 3x caused OpenGL to run out of memory and abort.

Fixed this by putting the resources into drawable-nodpi, which means Android will not scale them.

I wonder if this means we run into other memory problems where we scale images from drawable/ up?

[1] http://stackoverflow.com/a/14877627/582004

Comment 9

[Chenxia Liu [:liuche]]

Comment on attachment 8675979 [details]
MozReview Request: Bug 1207404 - First run image is too small. r=sebastian

Bug 1207404 - First run image is too small. r=sebastian

Comment 10

[Chenxia Liu [:liuche]]

Tree's closed, here's the try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=abc53a09a972

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/bde31d612d08

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bde31d612d08