1207407 - Raptor doesn't work with node 4.x

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Trying to launch raptor in node-4.1 results in:

zbraniecki@zbmba:~$ raptor test coldlaunch --app camera --runs 31
internal/child_process.js:400
  const control = new class extends EventEmitter {
                      ^^^^^

SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
    at runInThisContext (node.js:857:18)
    at NativeModule.compile (node.js:941:14)
    at NativeModule.require (node.js:890:18)
    at child_process.js:12:23
    at NativeModule.compile (node.js:942:5)
    at Function.NativeModule.require (node.js:890:18)
    at Function.Module._load (module.js:295:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/usr/local/lib/node_modules/raptor/node_modules/rapido/node_modules/npm/node_modules/child-process-close/index.js:2:21)
zbraniecki@zbmba:~$ node --version
v4.1.0

Comment 1

[:Eli Perelman]

What npm version? I see rapido as a first-level dependency which isn't a direct raptor dependency, so wondering.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

zbraniecki@zbmba:~/projects/gaia (master %>)$ npm --version
2.14.4

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

That's the installation log:

zbraniecki@zbmba:~$ npm install -g raptor
npm WARN engine npm@1.2.8000: wanted: {"node":">=0.8","npm":"1"} (current: {"node":"4.1.0","npm":"2.14.4"})
/usr/local/bin/raptor -> /usr/local/lib/node_modules/raptor/bin/raptor
/usr/local/bin/raptor-jsdoc -> /usr/local/lib/node_modules/raptor/bin/raptor-jsdoc
/usr/local/bin/raptor-optimizer -> /usr/local/lib/node_modules/raptor/bin/raptor-optimizer
raptor@2.6.17 /usr/local/lib/node_modules/raptor
├── cookie@0.1.5
├── mime@1.2.11
├── path-filters@1.0.6
├── q@0.9.7
├── xmldom@0.1.19
├── sqwish@0.2.2
├── coffee-script@1.10.0
├── minimatch@0.2.14 (sigmund@1.0.1, lru-cache@2.7.0)
├── dustjs-helpers@1.1.2
├── optimist@0.3.7 (wordwrap@0.0.3)
├── sax@0.4.3
├── dustjs-linkedin@1.2.6
├── uglify-js@1.3.5
├── esprima@0.9.9
├── rapido-raptorjs@0.3.8
├── less@1.3.3 (ycssmin@1.0.1)
└── rapido@0.2.24 (colors@0.6.2, prompt@0.2.14, cli-color@0.2.3, raptor@2.4.44, npm@1.2.8000)

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Agh. Ok. So I was trying to install "raptor" instead of "@mozilla/raptor".

Now the installation log looks more like it should:

zbraniecki@zbmba:~$ npm install -g @mozilla/raptor
|
> sockit-to-me@0.3.2 install /usr/local/lib/node_modules/@mozilla/raptor/node_modules/marionette-client/node_modules/sockit-to-me
> ./tools/copy.js || node-gyp configure build

[sockit-to-me] platform not linux
make: *** No rule to make target `Release/obj.target/sockit/src/node-0.1./addon.o', needed by `Release/sockit.node'.  Stop.
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 14.0.0
gyp ERR! command "/usr/local/Cellar/node/4.1.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "build"
gyp ERR! cwd /usr/local/lib/node_modules/@mozilla/raptor/node_modules/marionette-client/node_modules/sockit-to-me
gyp ERR! node -v v4.1.0
gyp ERR! node-gyp -v v3.0.1
gyp ERR! not ok 
npm ERR! Darwin 14.0.0
npm ERR! argv "/usr/local/Cellar/node/4.1.0/bin/node" "/usr/local/bin/npm" "install" "-g" "@mozilla/raptor"
npm ERR! node v4.1.0
npm ERR! npm  v2.14.4
npm ERR! code ELIFECYCLE

npm ERR! sockit-to-me@0.3.2 install: `./tools/copy.js || node-gyp configure build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the sockit-to-me@0.3.2 install script './tools/copy.js || node-gyp configure build'.
npm ERR! This is most likely a problem with the sockit-to-me package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     ./tools/copy.js || node-gyp configure build
npm ERR! You can get their info via:
npm ERR!     npm owner ls sockit-to-me
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/zbraniecki/npm-debug.log

Comment 5

[:Eli Perelman]

This should now be fixed in Raptor v4.0.0.