1207496 - Remove use of expression closure from services/.

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tooru Fujisawa [:arai]]

Need to replace non-standard expression closure with one of:
  * function declaration
  * function expression
  * arrow function
before fixing bug 1083458.

converting rules are following:
  * function declaration
    add `return` and braces
  * standalone named function expression
    add `return` and braces
  * standalone anonymous function expression contans and receives `this` (Array.filter, bind, etc)
    convert to arrow function, and remove code passing |this|
  * standalone anonymous function expression contans no `this`
    convert to arrow function
  * property with anonymous function expression, contains `this`
    add `return` and braces
  * property with anonymous function expression, contains no `this`, short body
    convert to arrow function
  * property with anonymous function expression, contains no `this`, long body
    add `return` and braces
  * property with named function expression
    add `return` and braces
  * getter property
    add `return` and braces
  * setter property
    add braces

Since there are a lot of patches, separated into 8 bugs, each bug corresponds to one of following directories:
  * browser/, except browser/components/.
  * browser/components/.
  * dom/.
  * layout/.
  * services/.
  * toolkit/, except toolkit/components/.
  * toolkit/components/.
  * b2g/, chrome/, docshell/, mobiles/, modules/, netwerk/, parser/, security/, storage/, testing/, webapprt/, widget/, xpcom/
(not yet touched addon-sdk)

I have draft patches, will post them (may take some time to prepare and post).

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Part 1: Remove use of expression closure from services/common/.

Additional rule:
  * function expression, contains `arguments`
    add `return` and braces

Almost green on try run: (with other patches, M(13) is not related)
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=c844b363eef3

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Part 2: Remove use of expression closure from services/crypt/.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Part 3: Remove use of expression closure from services/fxaccounts/.

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Part 4: Remove use of expression closure from services/sync/.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8666791 [details] [diff] [review]
Part 1: Remove use of expression closure from services/common/.

Review of attachment 8666791 [details] [diff] [review]:
-----------------------------------------------------------------

Expression closures were never part of our coding style in services - surprised to see them :/ This is why we need automatic linting.

LGTM.

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8666795 [details] [diff] [review]
Part 4: Remove use of expression closure from services/sync/.

Review of attachment 8666795 [details] [diff] [review]:
-----------------------------------------------------------------

I mostly glazed over this. But LGTM.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8666793 [details] [diff] [review]
Part 2: Remove use of expression closure from services/crypt/.

Review of attachment 8666793 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know if I'm technically a peer here, but this is pretty obvious.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1cfe6acea8f3
https://hg.mozilla.org/integration/mozilla-inbound/rev/33fd45d1b555
https://hg.mozilla.org/integration/mozilla-inbound/rev/71df142400cf
https://hg.mozilla.org/integration/mozilla-inbound/rev/04ff035c4507

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1cfe6acea8f3
https://hg.mozilla.org/mozilla-central/rev/33fd45d1b555
https://hg.mozilla.org/mozilla-central/rev/71df142400cf
https://hg.mozilla.org/mozilla-central/rev/04ff035c4507