1207536 - [Control Center] Incorrect doorhanger placement for the Identity Extended Subview

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[Cornel Ionce [:noni] [Hubs QA]]

Reproduced on Windows 10 64-bit with:
* 42.0 beta 1
* latest 43.0a2 Aurora
* latest 44.0a1 Nightly

STR:
1. Open Firefox.
2. Navigate to https://timtaubert.de/ 
3. Move the broswer close to the bottom of the screen
4. Click on the site identity panel and then on the ">" button.

Expected Results:
The subview is correctly displayed.

Actual Results:
The doorhanger is missplaced, displayed at the top of the pop`up instead of bottom.

Screenshot: http://i.imgur.com/qvoQ3Wl.jpg

Comment 1

[Brian Grinstead [:bgrins]]

This looks like an issue with the XUL panel.  Does this happen on other versions of Windows?

Comment 2

[Cornel Ionce [:noni] [Hubs QA]]

It seems that this is reproducing across platform.

I've tested on Windows 7 64-bit, Windows 8 32-bit, Ubuntu 12.04 32-bit and Mac OS X 10.9.5 and they are all affected.

Comment 3

[Brian Grinstead [:bgrins]]

OK I see it now, thanks.  The panel arrow never gets re-anchored when switching into the subview if the main view opened in the bottom at first.  If you get it to open the main view above the browser in the first place than the arrow is correct.

Comment 4

[Brian Grinstead [:bgrins]]

Looks like this started happening after 41

Comment 5

[Brian Grinstead [:bgrins]]

It looks like this is an issue with the XUL panel where the positioning is being updated but the arrow icon that anchors it to the ID block isn't moving.

Comment 6

[Brian Grinstead [:bgrins]]

Matt, do you think this is a duplicate of Bug 1188400?

Comment 7

[Neil Deakin]

Does the patch in bug 1206133 fix this?

Comment 8

[Brian Grinstead [:bgrins]]

Attachment: arrow-up.png

(In reply to Neil Deakin from comment #7)
> Does the patch in bug 1206133 fix this?

No, tested with the patch applied locally and the arrow is still showing up on the top side of Control Center after expanding the subview.  To make sure that the subview is taller than the main view I've set this in the CSS:

#identity-popup-permissions-content {
  display: none;
}

Comment 9

[Neil Deakin]

I updated the patch in bug 1206133 and it should address this case.

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

I just tested and this is now fixed by the patch in bug 1206133.