1207568 - Non booting system when using Nexus 5 L blobfree

Status: RESOLVED FIXED

(Firefox OS Graveyard :: B2gInstaller, defect)

Description

[:gerard-majax]

STR:
 0. Grab a Nexus 5 Lollipop user build (B, not Be on TaskCluster)
 1. Flash the blobfree system with the addon

Expected:
 Device boots

Actual:
 Device does not boots

Comment 1

[:gerard-majax]

Flashing full nexus-5-l user build works.

Comment 2

[:gerard-majax]

Flashing nexus-5-l user boot partition, device still does not boot.

Comment 3

[:gerard-majax]

Flashing nexus-5-l user system partition device boots.

Comment 4

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #3)
> Flashing nexus-5-l user system partition device boots.

The only difference I could spot was:
 - recovery-from-boot.p
 - bin/install-recovery.sh

Both are not present on the system partition that boots. But are present on the non booting one.

On a system partition built by the addon, once removed the previous recovery stuff, there is still a 4KB difference:
> sending 'system' (303792 KB)...

When the image ready to flash from nexus-5-l.zip:
> sending 'system' (303796 KB)...

Comment 5

[:gerard-majax]

On build system:
> make_ext4fs -s -T -1 -S out/target/product/hammerhead/root/file_contexts -l 1073741824 -a system out/target/product/hammerhead/obj/PACKAGING/systemimage_intermediates/system.img out/target/product/hammerhead/system
> Creating filesystem with parameters:
>   Size: 1073741824
>   Block size: 4096
>   Blocks per group: 32768
>   Inodes per group: 8192
>   Inode size: 256
>   Journal blocks: 4096
>   Label:
>   Blocks: 262144
>   Block groups: 8
>   Reserved block group size: 63
> Created filesystem with 1103/65536 inodes and 79781/262144 blocks

In addon:
> -s -l 1073741824 -a system
> Creating filesystem with parameters:
>   Size: 1073741824
>   Block size: 4096
>   Blocks per group: 32768
>   Inodes per group: 8192
>   Inode size: 256
>   Journal blocks: 4096
>   Label: 
>   Blocks: 262144
>   Block groups: 8
>   Reserved block group size: 63
> Created filesystem with 1104/65536 inodes and 79781/262144 blocks

Comment 6

[:gerard-majax]

So this is because we do not push the file_contexts for SELinux. Rebuilding by hand a system image with and without, I do reproduce 100%.

Comment 7

[:gerard-majax]

Attachment: B2G Installer PR

Works on Linux, but we may have a problem with the hacked make_ext4fs on Mac ...

Comment 8

[:gerard-majax]

Comment on attachment 8664875 [details] [review]
B2G Installer PR

ok that might be failing to build userdata partition

Comment 9

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #8)
> Comment on attachment 8664875 [details] [review]
> B2G Installer PR
> 
> ok that might be failing to build userdata partition

When calling make_ext4fs we are passing "-a userdata" but file_contexts seems to define "data" and not "userdata".

Comment 10

[:gerard-majax]

It looks like system boots without "-S ..." on userdata partition.

Comment 11

[:gerard-majax]

Comment on attachment 8664875 [details] [review]
B2G Installer PR

Successfully flashed a Nexus 5 L from Android to B2G from a Mac !

Comment 12

[:gerard-majax]

Vosky, once we and this, it's going to bring us usable blobfree from the addon for Nexus 5 Lollipop :)

Comment 13

[:gerard-majax]

... once we land ...

Comment 14

[Dale Harvey (:daleharvey)]

Comment on attachment 8664875 [details] [review]
B2G Installer PR

I cant test this, no nexus 5 here, however the code looks great and you have tested it so happy to lgtm

Comment 15

[:gerard-majax]

Produced a blobfree Nexus 5 Lollipop earlier today, flashed successfully from a Mac.

Comment 16

[:gerard-majax]

Produced a blobfree Nexus 4 Kitkat earlier today, flashed successfully from a Mac.

Comment 17

[:gerard-majax]

https://github.com/mozilla-b2g/b2g-installer/commit/bd8c0b06c033fe93c1cfb152ee26edc2083f6806