1207616 - [New-Homescreen] Sometimes paging/scrolling doesn't work correctly on startup

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Chris Lord [:cwiiis]]

This seems to be a recent regression, and I imagine the cause is down to something changing in Gecko or Gaia with respect to window sizes on startup/app start. It's probably best to mitigate this possible failure in homescreen (as I think it's possible to force it in other ways) and just handle the window resizing.

Comment 1

[Chris Lord [:cwiiis]]

Ok, this isn't as simple as I thought, and it seems to be caused by some difference with animations not running the same as they used to? Debugging is harder at the moment because WebIDE is broken...

Comment 2

[Chris Lord [:cwiiis]]

Actually, I'm totally wrong, this is much simpler than any of that, great :)

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1207616-new-homescreen-refresh-on-invisible-first-child > mozilla-b2g:master

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 8664898 [details] [review]
[gaia] Cwiiis:bug1207616-new-homescreen-refresh-on-invisible-first-child > mozilla-b2g:master

The bug would happen if the first added app had a hidden role, but I've also fixed the resize case too which I've seen rarely in certain situations.

Comment 5

[Alberto Pastor [:albertopq]]

Comment on attachment 8664898 [details] [review]
[gaia] Cwiiis:bug1207616-new-homescreen-refresh-on-invisible-first-child > mozilla-b2g:master

You know more about this code than me, but the change seems reasonable (and well tested) to me, so r+. Thanks!

Comment 6

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/354c6df3e80fef32b0fa2f24494ea83276795c0e