1207637 - Inspector's scroll into view feature doesn't check node types on the server

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Patrick Brosset <:pbro>]

In the markup-view, you can right-click any node and choose the scroll-into-view item to move that node into view.
For now, this feature is checking for node types on the client-side, like if a node is a Text node, the item isn't available.
But no checks are done on the server.

In bug 1203147, we added a keyboard shortcut to the inspector where, if you press S when a node is selected, that node gets moved into view, but the client-side checking mechanism wasn't used for that.

So, STR:
- open the inspector
- select a TEXT node
- press S

==> The following exception appears in the logs:

console.error: 
  Message: TypeError: this.rawNode.scrollIntoView is not a function
  Stack:
    exports.NodeActor<.scrollIntoView<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:649:5
actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1013:19
DSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1596:15
ChildDebuggerTransport.prototype.receiveMessage@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/shared/transport/transport.js:742:5

I think the server-side implementation of scrollIntoView should check if the method exist, and we should also be re-using the client-side check when S is pressed.

Comment 1

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1207637 - [devtools] Add guard in NodeActor#scrollIntoView. r=#devtools.

The RDP method can be called for a Node actor whose underlying node
doesn't have the scrollIntoViewMethod (e.g. a Text or a Comment).
Use the same method between the context menu entry and the keyboard shortcut
to bail out when scrollIntoView isn't supported by the selected node.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7e37d0c7114
[devtools] Add guard in NodeActor#scrollIntoView. r=devtools-reviewers,jdescottes.

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b7e37d0c7114