Don't hide australis menu (≡) after clicking "Move to Toolbar" in context menu.

VERIFIED FIXED in Firefox 44

Status

()

Firefox
Toolbars and Customization
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: arni2033, Assigned: Gijs)

Tracking

Trunk
Firefox 44
Points:
---

Firefox Tracking Flags

(firefox44 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8664897 [details]
screenshot - Don't hide australis menu (≡) after clicking 'Move to Toolbar' in context menu.png

STR:   (Win7_64, Nightly 44, 32bit, ID 20150922030204, new profile, safe mode)
1. Click (≡), hover mouse over any button in that menu, right-click on that button.
2. Click "Move to Toolbar" menuitem in context menu.

RESULT:
The chosen button was moved to toolbar, and menu collapsed

EXPECTATIONS:
The menu should stay visible, because user may want to continue customizing. If I, let say, need to move 3 items to toolbar - I have to open menu 3 times OR enter customize mode. I could perform the same operation faster if menu wouldn't hide every time an item was moved to toolbar

NOTE:
I first thought that it's an enhancement, but noticed that it's actually inconsistency, because if in Step 2 you choose menuitem by pressing Up and Down keys, and then pressing Enter, menu doesn't collapse
(Assignee)

Comment 1

3 years ago
(In reply to arni2033 from comment #0)
> I first thought that it's an enhancement, but noticed that it's actually
> inconsistency, because if in Step 2 you choose menuitem by pressing Up and
> Down keys, and then pressing Enter, menu doesn't collapse

That's a bug in the behaviour for Enter. The behaviour with the mouse is the one that's expected.

Philipp, thoughts?
Flags: needinfo?(philipp)
(Reporter)

Comment 2

3 years ago
(In reply to :Gijs Kruitbosch from comment #1)
> The behaviour with the mouse is the one that's expected.
Woah?! I've changed my mind, I don't experience this bug anymore. Please don't "fix" Enter key   v_v
Hm, I'm a bit confused, since I seem to get the exact opposite behavior:
- Selecting »Move to toolbar« with the mouse => Menu closes
- Selecting »Move to toolbar« with the keyboard => Menu stays open

Leaving the menu open seems like the better choice to me.
Flags: needinfo?(philipp)
Oh, and I should really start paying more attention when reading bug, sorry.

Still, leaving the menu open makes sense to me, since it provides a bit more context (you see the item disappearing and re-appearing in the toolbar).
(Assignee)

Comment 5

3 years ago
Created attachment 8673070 [details]
MozReview Request: Bug 1207641 - keep panel open when moving items to toolbar / to palette, r?MattN

Bug 1207641 - keep panel open when moving items to toolbar / to palette, r?MattN
Attachment #8673070 - Flags: review?(MattN+bmo)
(Assignee)

Comment 6

3 years ago
FWIW, I looked at the keypress case and I can't work out why we're not getting that. Even attaching system event listeners (or normal ones) to the actual menuitem got me nothing on OS X. No idea what's going on. If you have ideas, Matt, that'd be helpful. Not sure if this isn't causing wrong behaviour in other cases. Anyway, this fixes the issue at hand.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8673070 [details]
MozReview Request: Bug 1207641 - keep panel open when moving items to toolbar / to palette, r?MattN

https://reviewboard.mozilla.org/r/21841/#review19615

The diff LGTM
Attachment #8673070 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/7f6092c6c26d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
QA Whiteboard: [good first verify]
(Reporter)

Updated

2 years ago
Has STR: --- → yes
Reproduced this bug with Firefox Nightly 44.0a1 (2015-09-23) (Build ID: 20150923030230) on Linux, 64 Bit

This Bug is now verified as fixed on Latest Firefox Beta 44.0b7 

Build ID: 20160107144911
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
QA Whiteboard: [good first verify] → [good first verify][testday-20160108]
(Assignee)

Updated

2 years ago
Status: RESOLVED → VERIFIED
status-firefox44: fixed → verified
Comment hidden (obsolete)
You need to log in before you can comment on or make changes to this bug.