Fix comment at head of Barrier.h and reorganize to match the comment layout

RESOLVED FIXED in Firefox 44

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

(Blocks: 1 bug)

Trunk
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8665032 [details] [diff] [review]
reorganize_Barrier_h-v0.diff
Attachment #8665032 - Flags: review?(sphink)
Comment on attachment 8665032 [details] [diff] [review]
reorganize_Barrier_h-v0.diff

Review of attachment 8665032 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/Barrier.h
@@ +145,2 @@
>   *  |
> + * HeapSlot               specialization of HeapPtr for slots storage

Hm. Calling this a specialization is confusing, since it isn't one in the C++ sense. "like HeapPtr, but optimized for slots storage"? Or maybe:

  s/like/similar to/?
  s/optimized for/tailored to/?
  s/like/same as/?

I dunno.

@@ +399,5 @@
>  class HeapPtr : public BarrieredBase<T>
>  {
>    public:
>      HeapPtr() : BarrieredBase<T>(GCMethods<T>::initial()) {}
> +    explicit HeapPtr(T v) : BarrieredBase<T>(v) { this->post(GCMethods<T>::initial(), v); }

can you split this out into multiple lines? I think it'd make it easier to see the commonality with the following constructor.
Attachment #8665032 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/0196ec8d7884
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.