Closed
Bug 1207730
Opened 9 years ago
Closed 9 years ago
Fix comment at head of Barrier.h and reorganize to match the comment layout
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
19.92 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8665032 -
Flags: review?(sphink)
Comment 1•9 years ago
|
||
Comment on attachment 8665032 [details] [diff] [review]
reorganize_Barrier_h-v0.diff
Review of attachment 8665032 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/gc/Barrier.h
@@ +145,2 @@
> * |
> + * HeapSlot specialization of HeapPtr for slots storage
Hm. Calling this a specialization is confusing, since it isn't one in the C++ sense. "like HeapPtr, but optimized for slots storage"? Or maybe:
s/like/similar to/?
s/optimized for/tailored to/?
s/like/same as/?
I dunno.
@@ +399,5 @@
> class HeapPtr : public BarrieredBase<T>
> {
> public:
> HeapPtr() : BarrieredBase<T>(GCMethods<T>::initial()) {}
> + explicit HeapPtr(T v) : BarrieredBase<T>(v) { this->post(GCMethods<T>::initial(), v); }
can you split this out into multiple lines? I think it'd make it easier to see the commonality with the following constructor.
Attachment #8665032 -
Flags: review?(sphink) → review+
Comment 3•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•