1207730 - Fix comment at head of Barrier.h and reorganize to match the comment layout

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: reorganize_Barrier_h-v0.diff

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8665032 [details] [diff] [review]
reorganize_Barrier_h-v0.diff

Review of attachment 8665032 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/Barrier.h
@@ +145,2 @@
>   *  |
> + * HeapSlot               specialization of HeapPtr for slots storage

Hm. Calling this a specialization is confusing, since it isn't one in the C++ sense. "like HeapPtr, but optimized for slots storage"? Or maybe:

  s/like/similar to/?
  s/optimized for/tailored to/?
  s/like/same as/?

I dunno.

@@ +399,5 @@
>  class HeapPtr : public BarrieredBase<T>
>  {
>    public:
>      HeapPtr() : BarrieredBase<T>(GCMethods<T>::initial()) {}
> +    explicit HeapPtr(T v) : BarrieredBase<T>(v) { this->post(GCMethods<T>::initial(), v); }

can you split this out into multiple lines? I think it'd make it easier to see the commonality with the following constructor.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0196ec8d7884

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0196ec8d7884