1207773 - UBSan: index out of bounds in parse_mb_syn_cavlc.cpp:915:60

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect)

Description

[Tyson Smith [:tsmith]]

Attachment: test_case.264

This was found with fuzzing+UBSan build.

Output from UBSan:
codec/decoder/core/src/parse_mb_syn_cavlc.cpp:915:60: runtime error: index -6 out of bounds for type 'uint16_t (*[6])[64]'

Which is referring to:
const uint16_t* kpDequantCoeff = pCtx->bUseScalingList ? pCtx->pDequant_coeff8x8[iMbResProperty - 6][uiQp] :
                                   g_kuiDequantCoeff8x8[uiQp];

Comment 1

[sijchen]

I believe we checked this before and we believed it is a false alarm? @Haibo

Comment 2

[Tyson Smith [:tsmith]]

Attachment: call_stack.txt

Comment 3

[Haibo Zhu]

I am sorry that this is not a false alarm. We have fixed this bug in the master branch commit b37cda2 and openh264v1.5 branch commit d6b1680, please help to verify it.

Comment 4

[Tyson Smith [:tsmith]]

This bug appears to be fixed. Tested with commit b37cda2. Thanks!