The new theme implementation of aqua widgets exhibits jiggling hover. This is caused by the theme code being given different rects to draw in at different times, offset by a pixel or two from one time to the next. I'm pretty sure it's a transformation/rounding problem, but I haven't been able to prove it yet.
sounds like other platforms (those where the twips/pixel is different from win32) are having problems just like these.
Created attachment 66015 [details] [diff] [review] fixes radiobutton jiggle, but not scrollbars we need to ensure that mPixelsToTwips is integral. This patch (taken from an old gtk patch) will do that. However, it still doesn't fix the issues with jiggling scrollbars.
can i get some r/sr love on this patch? dcone, care to look at the deviceContext changes? they mimic what dbaron did last year on gtk.
Does int/double produce int, or double? Don't you need to round the first line to really ensure it's an integer? BTW, October 1999 was more than two years ago. :-)
Created attachment 66017 [details] [diff] [review] ensure rounding by casting to nscoord make sure we round.
dbaron: better? i verified in the debugger (even before i added the explicit rounding) that mPixelsToTwips is 15.0.
sure, r=dbaron either way (although the second might be clearer). I just wasn't sure what double/int division does.
a=asa (on behalf of drivers)
int/double or double/int promotes the other operand to double, and the result is double. /be
where did 099 go? was i asleep? was i dreaming? this is not my beautiful house. this is not my beautiful wife.
nsbeta1+/topembed+ per ADT triage team/Chris Saari. How did I get here?
this will go away as part of the scrollbar rewrite in 115758
fixed with native widgets in 121440