Theme buttons/scrollbars jiggle

RESOLVED FIXED in mozilla1.0

Status

()

Core
XUL
P5
normal
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Mike Pinkerton (not reading bugmail), Assigned: Mike Pinkerton (not reading bugmail))

Tracking

({topembed+})

Trunk
mozilla1.0
PowerPC
Mac OS X
topembed+
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

16 years ago
The new theme implementation of aqua widgets exhibits jiggling hover. This is
caused by the theme code being given different rects to draw in at different
times, offset by a pixel or two from one time to the next.

I'm pretty sure it's a transformation/rounding problem, but I haven't been able
to prove it yet.
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Keywords: nsbeta1
Priority: -- → P1
Target Milestone: --- → mozilla0.9.9
(Assignee)

Comment 1

16 years ago
sounds like other platforms (those where the twips/pixel is different from
win32) are having problems just like these.
Depends on: 97861
(Assignee)

Comment 2

16 years ago
Created attachment 66015 [details] [diff] [review]
fixes radiobutton jiggle, but not scrollbars

we need to ensure that mPixelsToTwips is integral. This patch (taken from an
old gtk patch) will do that. However, it still doesn't fix the issues with
jiggling scrollbars.
(Assignee)

Comment 3

16 years ago
can i get some r/sr love on this patch? dcone, care to look at the deviceContext
changes? they mimic what dbaron did last year on gtk.

Comment 4

16 years ago
sr=hyatt
Does int/double produce int, or double?  Don't you need to round the first line
to really ensure it's an integer?

BTW, October 1999 was more than two years ago. :-)
(Assignee)

Comment 6

16 years ago
Created attachment 66017 [details] [diff] [review]
ensure rounding by casting to nscoord

make sure we round.
Attachment #66015 - Attachment is obsolete: true
(Assignee)

Comment 7

16 years ago
dbaron: better?

i verified in the debugger (even before i added the explicit rounding) that
mPixelsToTwips is 15.0.
sure, r=dbaron either way (although the second might be clearer).  I just wasn't
sure what double/int division does.

Comment 9

16 years ago
a=asa (on behalf of drivers)
Keywords: mozilla0.9.8+
int/double or double/int promotes the other operand to double, and the result is
double.

/be

Updated

16 years ago
Keywords: mozilla0.9.8+
(Assignee)

Comment 11

16 years ago
where did 099 go? was i asleep? was i dreaming? this is not my beautiful house.
this is not my beautiful wife.
Target Milestone: mozilla0.9.9 → mozilla1.0
(Assignee)

Updated

16 years ago
Keywords: topembed

Comment 12

16 years ago
nsbeta1+/topembed+ per ADT triage team/Chris Saari.  How did I get here?
Keywords: nsbeta1, topembed → nsbeta1+, topembed+
(Assignee)

Comment 13

16 years ago
this will go away as part of the scrollbar rewrite in 115758
Depends on: 115758
Priority: P1 → P5
(Assignee)

Comment 14

16 years ago
fixed with native widgets in 121440
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.