1207790 - Fix sandbox build on old Linux kernels (2.6.28 through 2.6.39)

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

This was reported on IRC #boxing last night (in my time zone's “night”, anyway):

23:11 < arlolra> anyone seen this before?
23:11 < arlolra> 14:37.47 
/var/tmp/tmp.fasPeCKAag/instantbird-a3192a7cdb5a/mozilla/security/sandbox/linux/SandboxFilterUtil.cpp:84:43: error: 'SYS_RECVMMSG' was not declared in this scope
23:11 < arlolra> 14:37.47 DISPATCH_SOCKETCALL(__NR_recvmmsg, SYS_RECVMMSG);

I didn't have a chance to ask that a bug be filed, but I think I know what's going on here.  SandboxFilterUtil.cpp does this:

#ifndef SYS_ACCEPT4
// Android's kernel headers don't define these.
#define SYS_ACCEPT4  18
#define SYS_RECVMMSG 19
#define SYS_SENDMMSG 20
#endif

Which means that if your kernel headers are new enough to define SYS_ACCEPT4 but not SYS_RECVMMSG, you'll get that error.  The commits involved are:

accept4: de11defebf00, in 2.6.28
recvmmsg: a2e2725541fa, in 2.6.33
sendmmsg: 228e548e6020, in 3.0

This hasn't affected any of the Tier 1 build platforms, but it's simple enough to ifndef each define separately (and edit the comment) to fix it.

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Attachment: bug1207790-netcall-build-hg0.diff

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=69e0f800fba4

Also, noting that this is fallout from bug 1055310, so affects branches back to 41 (and was reported on 41 in bug 1219141).  I don't know what release management's policies are for non-Tier-1-only bugs (although the uplift risk is basically zero), but it's worth having on record at least.

Comment 4

[Carsten Book [:Tomcat]]

(In reply to Jed Davis [:jld] from comment #3)
> Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=69e0f800fba4
> 
> Also, noting that this is fallout from bug 1055310, so affects branches back
> to 41 (and was reported on 41 in bug 1219141).  I don't know what release
> management's policies are for non-Tier-1-only bugs (although the uplift risk
> is basically zero), but it's worth having on record at least.

cc'ing sylvestre and liz to this bug, they might have a answer to you to that question about policies

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5cbef5458e6b

Comment 6

[Sylvestre Ledru [:Sylvestre]]

This is too late for 42 as the release date is tomorrow but still have time for 43.
Please submit and uplift request.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Yes I would like this for 43 before I start the build.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Don't bother about this one. As 2.6.39 is very old, there is no rush.

Comment 9

[Zenitur]

(In reply to Sylvestre Ledru [:sylvestre] from comment #8)
> Don't bother about this one. As 2.6.39 is very old, there is no rush.

I'm using RHED 6, because it's very stable. I didn't want to upgrade to 7 because of GNOME3 and because RHED costs money. I want threading optimizations from Firefox 40, and I have been applied a patch (that was posted yesterday) to the source code when upgrade Firefox version!

Is it bad? Much people are using Windows XP that released in 2002!

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Zenitur, we are discussing about building the software, not running it.

Comment 11

[Zenitur]

(In reply to Sylvestre Ledru [:sylvestre] from comment #10)
> Zenitur, we are discussing about building the software, not running it.

It's impossible to build on new environment when run on an old. If I'll try to build Firefox on RHEL 7 environment, when start that on 6, I will get "too old Glibc in your system, and where is your GTK3?". That's why I can build current Firefox for Enterprise Linux 6 only with EL ≤ 6.

Comment 12

[Zenitur]

when = then

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5cbef5458e6b

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/5cbef5458e6b

Comment 15

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Comment on attachment 8681525 [details] [diff] [review]
bug1207790-netcall-build-hg0.diff

Approval Request Comment
[Feature/regressing bug #]: Bug 1055310
[User impact if declined]: Build breakage on some non-Tier-1 systems (see comment #0 and bug 1219141)
[Describe test coverage new/current, TreeHerder]: It's been stable on m-c for a few days.
[Risks and why]: Effectively none; this patch shouldn't affect Tier 1 builds at all, and only affects whether the build is broken.
[String/UUID change made/needed]: None

Comment 16

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Also, anyone doing a build of one of the wontfix'ed versions on an affected system, or building packages of them for one, should be able to apply the patch locally.

Comment 17

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 18

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8681525 [details] [diff] [review]
bug1207790-netcall-build-hg0.diff

Taking it to help people developing on old kernels.
Should be in 43 beta 2.

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/24a44f2b15ca

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/89e3c373b3a4

Comment 21

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/24a44f2b15ca