1207915 - Apply the fix of bug 1052206 to DecodedStream

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[JW Wang [:jwwang] [:jw_wang]]

To prevent audio glitches resulted from rounding errors when converting usecs to frames. (see bug 1052206 comment 78 for the details)

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b32894d2249e

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1207915 - Apply the fix of bug 1052206 to DecodedStream.

Bug 1207915 - Apply the fix of bug 1052206 to DecodedStream.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8665250 [details]
MozReview Request: Bug 1207915 - Apply the fix of bug 1052206 to DecodedStream.

https://reviewboard.mozilla.org/r/20195/#review18107

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/84fd96dc7ddc

Comment 6

[Carsten Book [:Tomcat]]

sorry had to back this out seems this caused errors like https://treeherder.mozilla.org/logviewer.html#?job_id=14637149&repo=mozilla-inbound

Comment 7

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5bd632ebaff

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

See bug 1062686 where a few hundred failures were logged from this as well

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Ok, I found the problem.

When playing small-shot.ogg (rate=11127, duration=276085), we have
1st sample: start=0, end=92028, frames=1024
2nd sample: start=92028 end=184056 frames=1024

After sending the 1st sample, |mAudioFramesWritten| becomes 1024.
When sending the 2nd sample, we have
frame offset = 92028*11127/1000000 = 1023.995 =~ 1023 smaller than |mAudioFramesWritten==1024|.
So the 2nd sample is considered being sent already which is wrong.

I will check end times to determine whether a sample is processed or not to avoid such rounding errors.

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8665250 [details]
MozReview Request: Bug 1207915 - Apply the fix of bug 1052206 to DecodedStream.

Bug 1207915 - Apply the fix of bug 1052206 to DecodedStream.

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8665250 [details]
MozReview Request: Bug 1207915 - Apply the fix of bug 1052206 to DecodedStream.

Fix the problem in comment 9.
Try seems green this time: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2c0c6961b6a

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8665250 [details]
MozReview Request: Bug 1207915 - Apply the fix of bug 1052206 to DecodedStream.

https://reviewboard.mozilla.org/r/20195/#review18279

Comment 13

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf6d4bfd1756

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cf6d4bfd1756