Closed Bug 1207928 Opened 5 years ago Closed 5 years ago

Long press on a link will show both context menu and text selection dialog

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: TYLin, Assigned: apastor)

References

Details

Attachments

(1 file)

Step to reproduce:
1. Open an arbitrary webpage in browser app
2. Long press on a link

Actual results:
Both context menu and text selection dialog will show, and a word on the link is selected.

Expected result:
Show context menu only.
I do git bisect to find the possible regression in commit https://github.com/mozilla-b2g/gaia/commit/27a86ef0e13fa7d02417a5094bb2712a67a623ab from bug 1203999.

Hi Alberto, would you please take a look?
Depends on: 1203999
Flags: needinfo?(apastor)
Assignee: nobody → apastor
Flags: needinfo?(apastor)
Comment on attachment 8665456 [details] [review]
[gaia] albertopq:1207928-long-press-link2 > mozilla-b2g:master

Stopping event propagation after early returns when showing the context menu. Etienne, could you please take a look? Thanks!
Attachment #8665456 - Flags: review?(etienne)
Comment on attachment 8665456 [details] [review]
[gaia] albertopq:1207928-long-press-link2 > mozilla-b2g:master

r=me with the test added
Attachment #8665456 - Flags: review?(etienne) → review+
master: https://github.com/mozilla-b2g/gaia/commit/64cbcb532b538b36e92d99f66833a208e4a62e3e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1212700
You need to log in before you can comment on or make changes to this bug.