Closed
Bug 1207943
Opened 9 years ago
Closed 9 years ago
Assertion failure: scratch != InvalidReg, at c:/Users/mozilla/debug-builds/mozilla-central/js/src/ji t/MacroAssembler.cpp:156
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: cbook, Assigned: jandem)
References
()
Details
(Keywords: assertion, intermittent-failure)
Attachments
(2 files)
126.53 KB,
text/plain
|
Details | |
3.36 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
found via bughunter, reproduced on windows 7 debug builds Steps to reproduce: -> Load http://www.portalegeek.com/2014/10/scaricare-video-da-rai-replay-e-video.html --> Assertion failure: scratch != InvalidReg, at c:/Users/mozilla/debug-builds/mozilla-central/js/src/ji t/MacroAssembler.cpp:156
Reporter | ||
Comment 1•9 years ago
|
||
jonco: is this something for you ? seems this is somehow a regression
Flags: needinfo?(jcoppeard)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 4•9 years ago
|
||
As per IRC discussion, I didn't touch this code so clearing needinfo.
Flags: needinfo?(jcoppeard)
Assignee | ||
Comment 5•9 years ago
|
||
Bug 1207210 probably exposed this, will try to repro.
Flags: needinfo?(jdemooij)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 10•9 years ago
|
||
The assertion failure happens when we have MTypeBarrier with MIRType_ObjectOrNull, getObjectCount() == 0 and barrierKind == TypeSet. In that case we don't request a temp register so we can call guardObjectType with scratch == InvalidReg. This patch fixes the assert.
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Flags: needinfo?(jdemooij)
Attachment #8665915 -
Flags: review?(bhackett1024)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•9 years ago
|
Keywords: intermittent-failure
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•9 years ago
|
Attachment #8665915 -
Flags: review?(bhackett1024) → review+
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
https://hg.mozilla.org/mozilla-central/rev/abcc2798634a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•