1207995 - [TV 2.5] Provide remote control service current control mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Description

[Eric Tsai (no more review request accepted)]

Current control mode is for dispatch different event to app, for example, touch move for browser but gesture to page up/down for control home screen.

Comment 1

[Luke Chang [:lchang] (inactive)]

We've decided smart-system will notify Gecko of the mode-changed status via "mozContentEvent" event as follows:

{
  type: 'control-mode-changed',
  detail: {
    cursor: true / false
  }
}

And Gecko can request system to report the status actively by using "mozChromeRemoteControlEvent" as follows:

{
  type: 'request-control-mode',
  detail: null
}

Comment 2

[Luke Chang [:lchang] (inactive)]

This bug will be addressed in Gaia side so take it over from Eric.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1207995_tv_provide_control_mode > mozilla-b2g:master

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8672542 [details] [review]
[gaia] luke-chang:1207995_tv_provide_control_mode > mozilla-b2g:master

Hi Rex,

Could you please take a look at this? Thanks.

This patch hard-codes to detect if the currently-focused element is the browser app. If yes, it reports "cursor: true" to Gecko, and vice versa. So that Gecko can determine whether or not it needs to draw a cursor on it.

Comment 5

[Luke Chang [:lchang] (inactive)]

(In reply to Luke Chang [:lchang] from comment #1)
> And Gecko can request system to report the status actively by using
> "mozChromeRemoteControlEvent" as follows:
> 
> {
>   type: 'request-control-mode',
>   detail: null
> }

Protocol changed:

{
  action: 'request-control-mode'
}

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8672542 [details] [review]
[gaia] luke-chang:1207995_tv_provide_control_mode > mozilla-b2g:master

Looks good to me. Thank you!

Comment 7

[Luke Chang [:lchang] (inactive)]

(In reply to Luke Chang [:lchang] from comment #5)
> (In reply to Luke Chang [:lchang] from comment #1)
> > And Gecko can request system to report the status actively by using
> > "mozChromeRemoteControlEvent" as follows:
> 
> {
>   action: 'request-control-mode'
> }

Let me explain this more.

In case the HTTP server is, for some reason, initialized or rebooted after system app is loaded, it can retrieve the current control mode immediately by utilizing this event instead of waiting for the next "control-mode-changed" event.

Comment 8

[Luke Chang [:lchang] (inactive)]

tests passed: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=60feee58bd90c7ac0c9e4a554271e190599979c5

landed on master: https://github.com/mozilla-b2g/gaia/commit/ddc269c6c3ac40ee7216f7bfd2d30d22bc49071f