Closed Bug 1208166 Opened 4 years ago Closed 4 years ago

Re-enable View Source in Tab by default for all channels

Categories

(Toolkit :: View Source, defect)

43 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla44
Tracking Status
firefox41 --- unaffected
firefox42 --- verified
firefox43 --- verified
firefox44 --- verified
relnote-firefox --- 42+

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file)

In bug 1201535, view source in tab was disabled for Release / Beta channels until some issues are solved:

* Broken for srcdoc frames
* Extra GET requests

Bug 1201535 should be resolved soon, so it should be safe to re-enable for all channels.
Summary: Re-enable View Source in Tab by default → Re-enable View Source in Tab by default for all channels
In bug 1201535 comment 49, :bz agreed the fixes in bug 1201535 were sufficient to resolve the issues mentioned in comment 0 that we originally disabled view source tabs for.

The fixes in bug 1201535 have now been uplifted to beta (42), so I'd like to re-enable the feature and re-relnote the feature up to 42.
Bug 1208166 - Re-enable View Source in Tab for all channels. r=mconley
Attachment #8667577 - Flags: review?(mconley)
Comment on attachment 8667577 [details]
MozReview Request: Bug 1208166 - Re-enable View Source in Tab for all channels. r=mconley

https://reviewboard.mozilla.org/r/20783/#review18719

This is fine - though you mention in comment 0 that there was some kind of "extra GET requests" bug. I don't see that bug blocking this though... what was the bug number, out of curiosity, and was it fixed?
Attachment #8667577 - Flags: review?(mconley) → review+
(In reply to Mike Conley (:mconley) - Needinfo me! from comment #4)
> Comment on attachment 8667577 [details]
> MozReview Request: Bug 1208166 - Re-enable View Source in Tab for all
> channels. r=mconley
> 
> https://reviewboard.mozilla.org/r/20783/#review18719
> 
> This is fine - though you mention in comment 0 that there was some kind of
> "extra GET requests" bug. I don't see that bug blocking this though... what
> was the bug number, out of curiosity, and was it fixed?

Right, sorry, my fault for the confusion.  The fix for this was also in bug 1201535.  I've updated the bug summary just now.

The extra GET requests were caused by always opening a new tab with "view-source:<X>" URLs which triggers a GET, but then the view source module would do it's own load later on, possibly with the page descriptor.

Anyway, it was never necessary to open the tab with that URL, since we fix up the history and present the same URL later on.  So, we now open the tabs with "about:blank" which avoids the extra requests.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b276c71ae78e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8667577 [details]
MozReview Request: Bug 1208166 - Re-enable View Source in Tab for all channels. r=mconley

Approval Request Comment
[Feature/regressing bug #]: View source in tab was disabled on beta / release channels in bug 1201535 until that bug was resolved.  It has now been resolved and uplifted to aurora and beta.
[User impact if declined]: If declined, view source in window would be used on beta / release channels.
[Describe test coverage new/current, TreeHerder]: On m-c.
[Risks and why]: Should be low, we've resolved all known tab regressions at this point.
[String/UUID change made/needed]: None
Attachment #8667577 - Flags: approval-mozilla-beta?
Attachment #8667577 - Flags: approval-mozilla-aurora?
Comment on attachment 8667577 [details]
MozReview Request: Bug 1208166 - Re-enable View Source in Tab for all channels. r=mconley

Pref flip, test coverage exists, looks like Sylvestre gave the OK to this for beta in bug 1201535. Let's uplift this to aurora and beta.
Attachment #8667577 - Flags: approval-mozilla-beta?
Attachment #8667577 - Flags: approval-mozilla-beta+
Attachment #8667577 - Flags: approval-mozilla-aurora?
Attachment #8667577 - Flags: approval-mozilla-aurora+
Flags: qe-verify+
Added back to the release notes, same wording as before: "View HTML source in a tab"
With the a link to https://hacks.mozilla.org/2015/07/developer-edition-41-view-source-in-a-tab-screenshot-elements-har-files-and-more/

Ryan, we might want to update the blog post, don't you think?
Flags: needinfo?(jryans)
Hi, this cause problems while uplifting to beta:

grafting 306335:b276c71ae78e "Bug 1208166 - Re-enable View Source in Tab for all channels. r=mconley"
merging browser/app/profile/firefox.js
warning: conflicts during merge.
merging browser/app/profile/firefox.js incomplete! (edit conflicts, then use 'hg resolve --mark')
merging testing/profiles/prefs_general.js
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)

could you take a look, thanks!
(In reply to Sylvestre Ledru [:sylvestre] from comment #10)
> Added back to the release notes, same wording as before: "View HTML source
> in a tab"
> With the a link to
> https://hacks.mozilla.org/2015/07/developer-edition-41-view-source-in-a-tab-
> screenshot-elements-har-files-and-more/
> 
> Ryan, we might want to update the blog post, don't you think?

Thanks for the reminder, I've emailed the Hacks team to work on resolving this.
Flags: needinfo?(jryans)
Verified using https://bug964239.bmoattachments.org/attachment.cgi?id=8365919 with Firefox 42 beta 6, Aurora 43.0a2 and Nightly 44.0a1 2015-10-12 (Win 7 64-bit, Mac OS X 10.9.5) that the pref is true and the iframe source is opened in new tabs.
You need to log in before you can comment on or make changes to this bug.