120817 - Log Out and %commandmenu% in bannerhtml

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Chris Strahorn]

With %commandmenu% in bannerhtml, logging out from Bugzilla gives back the 
relogin page with the Log Out on header and Log In on the footer.

Steps to reproduce:
Add %commandmenu% in bannerhtml. Save the change. Navigate to any other page in 
Bugzilla so that the command menu is added to the header. Select the Log Out 
link from the FOOTER of the page. The relogin page is displayed with Log Out in 
the header command menu and Log In in the footer.

Solution:
This occurs because relogin.cgi calls delete $::COOKIE{"Bugzilla_login"}; after 
calling PutHeader ("Relogin"); This means that the call to quietly_check_login
() within GetCommandMenu() returns 1, and GetCommandMenu() displays the Log Out 
option.

Here's a patch:

Index: relogin.cgi
===================================================================
RCS file: /cvsroot/mozilla/webtools/bugzilla/relogin.cgi,v
retrieving revision 1.10
diff -p -r1.10 relogin.cgi
*** relogin.cgi 2000/01/18 14:41:00     1.10
--- relogin.cgi 2002/01/18 19:26:37
*************** Set-Cookie: Bugzilla_password= ; path=/;
*** 34,39 ****
--- 34,44 ----
  Content-type: text/html

  ";
+
+ # delete the cookie before dumping the header so that it shows the user
+ # as logged out
+ delete $::COOKIE{"Bugzilla_login"};
+
  PutHeader ("Relogin");

  print "<B>Your login has been forgotten</B>.</P>
*************** The cookie that was remembering your log
*** 41,48 ****
  do an action that requires a login, you will be prompted for it.
  <p>
  ";
-
- delete $::COOKIE{"Bugzilla_login"};

  PutFooter();

--- 46,51 ----

Comment 1

[Dave Miller [:justdave]]

Attachment: Chris's patch

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 65654 [details] [diff] [review]
Chris's patch

r= justdave

This looks pretty painless

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 65654 [details] [diff] [review]
Chris's patch

Code looks good. Functions as expected.
r=dkl

Comment 4

[David Lawrence [:dkl]]

Fix checked into HEAD on 01/18/2002. Closing as RESOLVED/FIXED.