Closed
Bug 1208203
Opened 9 years ago
Closed 9 years ago
Add a "printing..." indicator
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox44 fixed)
RESOLVED
FIXED
Firefox 44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: mfinkle, Assigned: mfinkle, Mentored)
References
Details
(Whiteboard: [lang=js])
Attachments
(1 file)
2.74 KB,
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
When starting a print job (bug 1078432), there can be a short pause before the page is converted to PDF. This bug is about adding a simple indicator to let the user know a print job has started. I don't think we even care about showing the the print job ended.... Android takes over and shows a UI. We could display a toast, like we do with downloads: http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/DownloadNotifications.jsm#77 The place to do it for printing is here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/PrintHelper.js#47 Just check for STATE_START.
Updated•9 years ago
|
Mentor: margaret.leibovic, s.kaspari
Whiteboard: [lang=js]
Comment 1•9 years ago
|
||
Yeah, a toast might be enough. Anthony, any opinion on what the text should look like?
Flags: needinfo?(alam)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mark.finkle
Assignee | ||
Comment 2•9 years ago
|
||
This patch adds a "Print job started..." toast, like the one we use for downloads.
Attachment #8667268 -
Flags: review?(s.kaspari)
Updated•9 years ago
|
Attachment #8667268 -
Flags: review?(s.kaspari) → review+
Comment 3•9 years ago
|
||
I think just "Printing..." is enough. Though technically not print "ing", I think the distinction is not sufficient enough to make a differentiation.
Flags: needinfo?(alam)
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/39a2036f52fb
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•