Closed Bug 1208203 Opened 5 years ago Closed 4 years ago

Add a "printing..." indicator

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: mfinkle, Assigned: mfinkle, Mentored)

References

Details

(Whiteboard: [lang=js])

Attachments

(1 file)

When starting a print job (bug 1078432), there can be a short pause before the page is converted to PDF. This bug is about adding a simple indicator to let the user know a print job has started. I don't think we even care about showing the the print job ended.... Android takes over and shows a UI.

We could display a toast, like we do with downloads:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/DownloadNotifications.jsm#77

The place to do it for printing is here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/PrintHelper.js#47
Just check for STATE_START.
Mentor: margaret.leibovic, s.kaspari
Whiteboard: [lang=js]
Yeah, a toast might be enough. Anthony, any opinion on what the text should look like?
Flags: needinfo?(alam)
Assignee: nobody → mark.finkle
This patch adds a "Print job started..." toast, like the one we use for downloads.
Attachment #8667268 - Flags: review?(s.kaspari)
Attachment #8667268 - Flags: review?(s.kaspari) → review+
I think just "Printing..." is enough. Though technically not print "ing", I think the distinction is not sufficient enough to make a differentiation.
Flags: needinfo?(alam)
https://hg.mozilla.org/mozilla-central/rev/39a2036f52fb
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.