1208300 - Remove gfxRGBA (part 3)

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nicholas Nethercote [inactive]]

A follow-up to 1208283, which continued removing gfxRGBA from the tree.

This bug will be enough to fully remove gfxRGBA.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove unused default arguments from ClearThebesSurface

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Convert gfxRGBA uses to gfx::Color in CompositorBench.cpp

I don't know how those modf() calls were compiling without error given that the
second arg was a |float*|.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Convert gfxRGBA uses to gfx::Color in LayerScope.cpp

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 4) - Remove gfxRGBA and some related things

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 8665746 [details] [diff] [review]
(part 1) - Remove unused default arguments from ClearThebesSurface

Ah, nice, ThebesLayerD3D9.cpp is gone now.

Comment 6

[Jonathan Watt [:jwatt]]

Comment on attachment 8665752 [details] [diff] [review]
(part 4) - Remove gfxRGBA and some related things

Review of attachment 8665752 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/42d49f3ce5bb
https://hg.mozilla.org/integration/mozilla-inbound/rev/d55473e74ae7
https://hg.mozilla.org/integration/mozilla-inbound/rev/169241058dde
https://hg.mozilla.org/integration/mozilla-inbound/rev/13feeea7a4a8

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/42d49f3ce5bb
https://hg.mozilla.org/mozilla-central/rev/d55473e74ae7
https://hg.mozilla.org/mozilla-central/rev/169241058dde
https://hg.mozilla.org/mozilla-central/rev/13feeea7a4a8