1208331 - [music] Fix checkPlayability (again)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Jim Porter (:squib)]

As in bug 1198169, valid audio files can (and usually do!) trigger the onsuspend event, so we can't use that as a fallback to detect broken audio files. Let's use a timeout like video, and then we'll land my "hide dotfiles" patch to help performance.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] jimporter:music-check-playability-fix > mozilla-b2g:master

Comment 2

[Hubert Figuiere [:hub]]

While it is fine on OGA, I can't get it to work with NGA. Last log lines are:

W/Music NGA( 7374): Content JS WARN: MediaDB: error parsing metadata for /sdcard1/sdcard/DCIM/100MZLLA/VID_0087.3gp : Error: Found video track in MP4 container 
W/Music NGA( 7374):     at metadataError (app://music-nga.gaiamobile.org/shared/js/mediadb.js:1916:1)

And it is stalled.

Comment 3

[Jim Porter (:squib)]

Are you sure that it works without my patch? I didn't touch any of the MP4-specific code.

Comment 4

[Hubert Figuiere [:hub]]

Yes it does work without your patch. Just checked again.

Comment 5

[Hubert Figuiere [:hub]]

OK, it actually does work on music-nga. The current caveat is that we don't rebuild metadata_scripts.js. Justin is working on fixing this for bug 1208154, so it will be good. BTW at that point we'll only need one fix.

Comment 6

[Hubert Figuiere [:hub]]

Comment on attachment 8665762 [details] [review]
[gaia] jimporter:music-check-playability-fix > mozilla-b2g:master

Ship it !

See my comment though.

Comment 7

[Jim Porter (:squib)]

(In reply to Hubert Figuiere [:hub] from comment #5)
> BTW at that point we'll only need one fix.

I think we'd need both anyway, since our goal should be to fix bugs in both NGA and OGA until we actually retire OGA for real. I don't want us to get near the end of 2.5, realize that NGA has some showstopping issue, and have nothing to fall back on.

Comment 8

[Jim Porter (:squib)]

Landed: https://github.com/mozilla-b2g/gaia/commit/586732250d6bd8f82647af8d64bbe9a10bc14259