1208345 - Remove gfxContext::GraphicsOperator

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nicholas Nethercote [inactive]]

Let's get rid of gfxContext::GraphicsOperator, in favour of gfx::CompositionOp.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove gfxContext::GraphicsOperator

I didn't set out to do it in one big patch, but once I tugged on a loose end it
didn't stop until I'd unraveled the whole ball of wool.

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 8665794 [details] [diff] [review]
Remove gfxContext::GraphicsOperator

Review of attachment 8665794 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxUtils.cpp
@@ +408,3 @@
>      } else {
>  #endif
> +        return CompositionOp::OP_SOURCE;

This would be much easier to read without the |else|.

Comment 3

[Jonathan Watt [:jwatt]]

(In reply to Nicholas Nethercote [:njn] from comment #1)
> I didn't set out to do it in one big patch, but once I tugged on a loose end
> it didn't stop until I'd unraveled the whole ball of wool.

Yeah, I had exactly the same problem when I was working on Moz2Dification. :)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7001f668518

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d7001f668518