Closed Bug 1208345 Opened 4 years ago Closed 4 years ago

Remove gfxContext::GraphicsOperator

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Let's get rid of gfxContext::GraphicsOperator, in favour of gfx::CompositionOp.
I didn't set out to do it in one big patch, but once I tugged on a loose end it
didn't stop until I'd unraveled the whole ball of wool.
Attachment #8665794 - Flags: review?(jwatt)
Comment on attachment 8665794 [details] [diff] [review]
Remove gfxContext::GraphicsOperator

Review of attachment 8665794 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxUtils.cpp
@@ +408,3 @@
>      } else {
>  #endif
> +        return CompositionOp::OP_SOURCE;

This would be much easier to read without the |else|.
Attachment #8665794 - Flags: review?(jwatt) → review+
(In reply to Nicholas Nethercote [:njn] from comment #1)
> I didn't set out to do it in one big patch, but once I tugged on a loose end
> it didn't stop until I'd unraveled the whole ball of wool.

Yeah, I had exactly the same problem when I was working on Moz2Dification. :)
https://hg.mozilla.org/mozilla-central/rev/d7001f668518
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.