Closed Bug 1208349 Opened 4 years ago Closed 4 years ago

[EME] canPlayType still broken on Windows N

Categories

(Core :: Audio/Video: Playback, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox42 --- fixed
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Despite my efforts in bug 1207376, canPlayType still functions incorrectly on Windows N when the WMF codecs are not installed (the default).

Now that I have a Windows N VM setup, fixing/testing this is a lot easier...
Note: The WMF PDM doesn't check to see if the MimeType has a codecs parameter, so there's not point putting an AAC/AVC codecs string there.
Attachment #8665800 - Flags: review?(jyavenard)
Attachment #8665800 - Flags: review?(jyavenard) → review+
Needs uplift in time for 42b2.
Flags: needinfo?(cpearce)
Patch applies cleanly to aurora and beta.
Comment on attachment 8665800 [details] [diff] [review]
Patch: Add SupportsMimeType call

Approval Request Comment
[Feature/regressing bug #]: EME/MSE/HTML5 video
[User impact if declined]: Users using Windows N variants will incorrectly report that they can play MP4/AAC/H.264 media. This means sites like YouTube and Netflix won't function correctly for these users. This is directly contributing to a significant number of failures on Netflix, and blocks Netflix shipping.
[Describe test coverage new/current, TreeHerder]: We have lots of unit tests covering media.
[Risks and why]: Low; we're checking explicitly that something will work before doing that thing.
[String/UUID change made/needed]: None.
Attachment #8665800 - Flags: approval-mozilla-beta?
Attachment #8665800 - Flags: approval-mozilla-aurora?
Comment on attachment 8665800 [details] [diff] [review]
Patch: Add SupportsMimeType call

Review of attachment 8665800 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/fmp4/MP4Decoder.cpp
@@ +330,5 @@
>  {
>    PlatformDecoderModule::Init();
>  
>    nsRefPtr<PlatformDecoderModule> platform = PlatformDecoderModule::Create();
> +  if (!platform || !platform->SupportsMimeType(NS_LITERAL_CSTRING("audio/mp4"))) {

This needed to be "audio/mp4a-latm". That's why it's only audio tests that are failing.
I went and landed this without approval on Aurora and Beta I won't be awake when 42Beta2 goes to build tomorrow and it's critical that we have this in the next beta. Sorry for not following procedure properly on this. I wouldn't do it if it wasn't important.
Flags: needinfo?(cpearce)
Comment on attachment 8665800 [details] [diff] [review]
Patch: Add SupportsMimeType call

Post-approved, we discussed that by email.
Attachment #8665800 - Flags: approval-mozilla-beta?
Attachment #8665800 - Flags: approval-mozilla-beta+
Attachment #8665800 - Flags: approval-mozilla-aurora?
Attachment #8665800 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/c2dec99392df
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.