1208349 - [EME] canPlayType still broken on Windows N

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Despite my efforts in bug 1207376, canPlayType still functions incorrectly on Windows N when the WMF codecs are not installed (the default).

Now that I have a Windows N VM setup, fixing/testing this is a lot easier...

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Add SupportsMimeType call

Note: The WMF PDM doesn't check to see if the MimeType has a codecs parameter, so there's not point putting an AAC/AVC codecs string there.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/188a6e9a86a0

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Needs uplift in time for 42b2.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Patch applies cleanly to aurora and beta.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8665800 [details] [diff] [review]
Patch: Add SupportsMimeType call

Approval Request Comment
[Feature/regressing bug #]: EME/MSE/HTML5 video
[User impact if declined]: Users using Windows N variants will incorrectly report that they can play MP4/AAC/H.264 media. This means sites like YouTube and Netflix won't function correctly for these users. This is directly contributing to a significant number of failures on Netflix, and blocks Netflix shipping.
[Describe test coverage new/current, TreeHerder]: We have lots of unit tests covering media.
[Risks and why]: Low; we're checking explicitly that something will work before doing that thing.
[String/UUID change made/needed]: None.

Comment 6

[Carsten Book [:Tomcat]]

sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=14696517&repo=mozilla-inbound
and https://treeherder.mozilla.org/logviewer.html#?job_id=14694737&repo=mozilla-inbound
and
https://treeherder.mozilla.org/logviewer.html#?job_id=14694734&repo=mozilla-inbound

Comment 7

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa0bd5b49975

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8665800 [details] [diff] [review]
Patch: Add SupportsMimeType call

Review of attachment 8665800 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/fmp4/MP4Decoder.cpp
@@ +330,5 @@
>  {
>    PlatformDecoderModule::Init();
>  
>    nsRefPtr<PlatformDecoderModule> platform = PlatformDecoderModule::Create();
> +  if (!platform || !platform->SupportsMimeType(NS_LITERAL_CSTRING("audio/mp4"))) {

This needed to be "audio/mp4a-latm". That's why it's only audio tests that are failing.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2dec99392df

Comment 10

[Jean-Yves Avenard [:jya]]

Oops

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ce0688d6632e

Comment 12

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/68577583aced

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

I went and landed this without approval on Aurora and Beta I won't be awake when 42Beta2 goes to build tomorrow and it's critical that we have this in the next beta. Sorry for not following procedure properly on this. I wouldn't do it if it wasn't important.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8665800 [details] [diff] [review]
Patch: Add SupportsMimeType call

Post-approved, we discussed that by email.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c2dec99392df