1208390 - Implement MediaStream.getTrackById()

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

Description

[Andreas Pehrson [:pehrsons]]

This seems trivial but wasn't covered by any other bug. We should implement this to make the API complete.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: MozReview Request: Bug 1208390 - Add test for MediaStream.getTrackById(). r?jib

Review commit: https://reviewboard.mozilla.org/r/54244/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54244/

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: MozReview Request: Bug 1208390 - Use MediaStream.getTrackById() in some existing tests. r?jib

Review commit: https://reviewboard.mozilla.org/r/54246/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54246/

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: MozReview Request: Bug 1208390 - Implement MediaStream.getTrackById(). r?jib, r?smaug

Review commit: https://reviewboard.mozilla.org/r/54248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54248/

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8754784 [details]
MozReview Request: Bug 1208390 - Implement MediaStream.getTrackById(). r?jib, r?smaug

https://reviewboard.mozilla.org/r/54248/#review50934

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8754782 [details]
MozReview Request: Bug 1208390 - Add test for MediaStream.getTrackById(). r?jib

https://reviewboard.mozilla.org/r/54244/#review50964

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8754783 [details]
MozReview Request: Bug 1208390 - Use MediaStream.getTrackById() in some existing tests. r?jib

https://reviewboard.mozilla.org/r/54246/#review50968

::: dom/media/tests/mochitest/pc.js:1134
(Diff revision 1)
>      return this._pc.getRemoteStreams().some(stream => {
> -      return stream.getTracks().some(pcTrack => pcTrack.id == track.id);
> +      return !!stream.getTrackById(track.id);

Nit: An opportunity to remove {} and return ?

::: dom/media/tests/mochitest/pc.js:1481
(Diff revision 1)
>      var inputElem = from.localMediaElements[0];
>  
>      // As input we use the stream of |from|'s first available audio sender.
>      var inputSenderTracks = from._pc.getSenders().map(sn => sn.track);
>      var inputAudioStream = from._pc.getLocalStreams()
> -      .find(s => s.getAudioTracks().some(t => inputSenderTracks.some(t2 => t == t2)));
> +      .find(s => inputSenderTracks.some(t => t.kind == "audio" && !!s.getTrackById(t.id)));

!! is redundant here.

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8754784 [details]
MozReview Request: Bug 1208390 - Implement MediaStream.getTrackById(). r?jib, r?smaug

https://reviewboard.mozilla.org/r/54248/#review50984

::: dom/media/DOMMediaStream.h:352
(Diff revision 1)
>    void GetAudioTracks(nsTArray<RefPtr<AudioStreamTrack> >& aTracks) const;
>    void GetVideoTracks(nsTArray<RefPtr<VideoStreamTrack> >& aTracks) const;
>    void GetTracks(nsTArray<RefPtr<MediaStreamTrack> >& aTracks) const;
> +  MediaStreamTrack* GetTrackById(const nsAString& aId);

Maybe const like the others here?

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc94f1f82084
https://hg.mozilla.org/integration/mozilla-inbound/rev/54985370fcd2
https://hg.mozilla.org/integration/mozilla-inbound/rev/3737024731e6

Comment 9

[Andreas Pehrson [:pehrsons]]

Try push was here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4054d608608e

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dc94f1f82084
https://hg.mozilla.org/mozilla-central/rev/54985370fcd2
https://hg.mozilla.org/mozilla-central/rev/3737024731e6

Comment 11

[Eric Shepherd [:sheppy]]

Document created: https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/getTrackById

Updated Firefox 49 for developers.