1208391 - KidFox: Restricted profile - Private browsing info should not be present in the history tab

Status: VERIFIED FIXED

Description

[u549602]

Nightly 44.0a1 09/24/2015
Device: Nexus tab 9 
Android 5.1.1

Steps to reproduce:
User is in About:home on a restricted profile with Private browsing disabled by owner
User visits History tab (no previous history made by user)

Actual result:
"Websites you visited most recently show up here
Psst:using a New Private Tab won't save your history"

Expected result 
As a restricted accout in history tab, the user should not be able to see "Psst:using a New Private Tab won't save your history" string while Private browsing disabled
 Note that by tapping on "New Private Tab" the settings menu is opened with no information about Private tabs (expected since private browsing is disabled). This may be a little confusing for the users
For further details please see https://youtu.be/r6ub-h6aZF8

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Good find! :)

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1208391 - Restricted profiles: Hide "private browsing" hint in empty state. r?mcomella

Bug 1208391 - Restricted profiles: Hide "private browsing" hint in empty state. r?mcomella

Comment 3

[Michael Comella (:mcomella) [needinfo or I won't see it]]

Comment on attachment 8666017 [details]
MozReview Request: Bug 1208391 - Restricted profiles: Hide "private browsing" hint in empty state. r?mcomella

https://reviewboard.mozilla.org/r/20409/#review18493

Damn, I really wish we had a better way of locking down private browsing. :(

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Michael Comella (:mcomella) from comment #3)
> Damn, I really wish we had a better way of locking down private browsing. :(

Yeah. This one doesn't even open a private tab but just open the menu. So I'm not sure if we would catch that even with some nice PB locking.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/699388c59ab2

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8666017 [details]
MozReview Request: Bug 1208391 - Restricted profiles: Hide "private browsing" hint in empty state. r?mcomella

Approval Request Comment

[Feature/regressing bug #]: Bug 1125290 - KidFox: Restricted profiles - Hide private browsing support and all related UI. Support for restricted profiles is targeting FxA 42.

[User impact if declined]: Empty state of history mentions "Private browsing" but feature is not available.

[Describe test coverage new/current, TreeHerder]: Local testing. No UI testing support for restricted profiles available yet.

[Risks and why]: Low. Patch is just hiding this text for restricted profiles (if PB is disabled).

[String/UUID change made/needed]: -

Comment 7

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/699388c59ab2

Comment 8

[Liz Henry (:lizzard) (use needinfo)]

Comment on attachment 8666017 [details]
MozReview Request: Bug 1208391 - Restricted profiles: Hide "private browsing" hint in empty state. r?mcomella

Low risk, small change in removing text. Approved for uplift to aurora.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cd3819abb9a2

Comment 10

[u549602]

Verified as fixed on latest Nightly(44.0a1 / 09/30/2015)

Comment 11

[Sylvestre Ledru [:sylvestre]]

Comment on attachment 8666017 [details]
MozReview Request: Bug 1208391 - Restricted profiles: Hide "private browsing" hint in empty state. r?mcomella

Just like Liz said.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/47614b0d507a

Comment 13

[u549602]

Verified as fixed on latest Aurora(43.0a2 / 10/04/2015)

Comment 14

[u421692]

Verified as fixed on Firefox 42 Beta 4 on Nexus 9(Android 5.1.1)