Closed Bug 1208391 Opened 5 years ago Closed 5 years ago

KidFox: Restricted profile - Private browsing info should not be present in the history tab

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 44
Tracking Status
firefox42 --- verified
firefox43 --- verified
firefox44 --- verified

People

(Reporter: u549602, Assigned: sebastian)

References

Details

Attachments

(1 file)

Nightly 44.0a1 09/24/2015
Device: Nexus tab 9 
Android 5.1.1

Steps to reproduce:
User is in About:home on a restricted profile with Private browsing disabled by owner
User visits History tab (no previous history made by user)

Actual result:
"Websites you visited most recently show up here
Psst:using a New Private Tab won't save your history"

Expected result 
As a restricted accout in history tab, the user should not be able to see "Psst:using a New Private Tab won't save your history" string while Private browsing disabled
 Note that by tapping on "New Private Tab" the settings menu is opened with no information about Private tabs (expected since private browsing is disabled). This may be a little confusing for the users
For further details please see https://youtu.be/r6ub-h6aZF8
OS: Unspecified → Android
Hardware: Unspecified → ARM
Blocks: FFB, kidfox-v1
Summary: As a restricted accout in history tab, the user should not be able to see "Psst:using a New Private Tab won't save your history" string while Private browsing disabled → KidFox:Restricted profile Private browsing info should not be present in the history tab in restricted profile
Summary: KidFox:Restricted profile Private browsing info should not be present in the history tab in restricted profile → KidFox: Restricted profile - Private browsing info should not be present in the history tab
Assignee: nobody → s.kaspari
Good find! :)
Status: NEW → ASSIGNED
Bug 1208391 - Restricted profiles: Hide "private browsing" hint in empty state. r?mcomella
Attachment #8666017 - Flags: review?(michael.l.comella)
Attachment #8666017 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8666017 [details]
MozReview Request: Bug 1208391 - Restricted profiles: Hide "private browsing" hint in empty state. r?mcomella

https://reviewboard.mozilla.org/r/20409/#review18493

Damn, I really wish we had a better way of locking down private browsing. :(
(In reply to Michael Comella (:mcomella) from comment #3)
> Damn, I really wish we had a better way of locking down private browsing. :(

Yeah. This one doesn't even open a private tab but just open the menu. So I'm not sure if we would catch that even with some nice PB locking.
Comment on attachment 8666017 [details]
MozReview Request: Bug 1208391 - Restricted profiles: Hide "private browsing" hint in empty state. r?mcomella

Approval Request Comment

[Feature/regressing bug #]: Bug 1125290 - KidFox: Restricted profiles - Hide private browsing support and all related UI. Support for restricted profiles is targeting FxA 42.

[User impact if declined]: Empty state of history mentions "Private browsing" but feature is not available.

[Describe test coverage new/current, TreeHerder]: Local testing. No UI testing support for restricted profiles available yet.

[Risks and why]: Low. Patch is just hiding this text for restricted profiles (if PB is disabled).

[String/UUID change made/needed]: -
Attachment #8666017 - Flags: approval-mozilla-beta?
Attachment #8666017 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/699388c59ab2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8666017 [details]
MozReview Request: Bug 1208391 - Restricted profiles: Hide "private browsing" hint in empty state. r?mcomella

Low risk, small change in removing text. Approved for uplift to aurora.
Attachment #8666017 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed on latest Nightly(44.0a1 / 09/30/2015)
Status: RESOLVED → VERIFIED
Status: VERIFIED → RESOLVED
Closed: 5 years ago5 years ago
Comment on attachment 8666017 [details]
MozReview Request: Bug 1208391 - Restricted profiles: Hide "private browsing" hint in empty state. r?mcomella

Just like Liz said.
Attachment #8666017 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on latest Aurora(43.0a2 / 10/04/2015)
Verified as fixed on Firefox 42 Beta 4 on Nexus 9(Android 5.1.1)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.