1208472 - Investigate: Avoiding gaps in history in split pane version of HistoryPanel

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Bug 1142171 introduced a "split pane" variant of the history panel (tablet + landscape). In this new version the user's history is split into different sections (Today, Yesterday, Last 7 days, ..). Currently we are limiting the number of items per section to 100 [1].

Potentially this limitation introduces gaps in history. For example:
* Today has more than 100 items and is cut off
* Yesterday 50 items
-> Gap between today's 100+ and yesterday
-> Last 7 days just shows today in this case

This bug is for investigating:
* Could we raise the limit to make gaps more unlikely?
* Could we even drop the limit (at least for some sections) because the query is already limited by time
* Is the Cursor based implementation stable enough to support more items?
* How do slow/old devices perform?

[1]: https://dxr.mozilla.org/mozilla-central/rev/e5effeb8e57ceddf679f7784faab0c2cebb1e1e6/mobile/android/base/home/HistoryPanel.java?offset=0#420

Comment 1

[:Margaret Leibovic]

I think we should consider dropping the limit. A lot has changed since the original implementation, so it might be worth going through history to see why we decided to have this limit in the first place.

Comment 2

[Jan Henning [:JanH]]

The combined history panel seems to use a total limit and then displays the section dividers as necessary.