Closed Bug 1208512 Opened 6 years ago Closed 6 years ago

Removed "about:home" text in URL bar causing testSettingsMenuItems test fail

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: mhaigh, Assigned: mhaigh)

References

Details

Attachments

(1 file)

In bug 1038996 the page title for about:home was removed.  This is breaking some tests but hasn't been picked up on try because our test settings disable the test on the two platforms that we can test on in try!  

Test config are:

[testSettingsMenuItems.java]
# disabled on Android 2.3, bug 979552; on 4.3, bug 1144898
skip-if = android_version == "10" || android_version == "18"

We should fix this test
Bug 1208512 - testSettingsMenuItems test failing; r?mcomella
Attachment #8666047 - Flags: review?(michael.l.comella)
Summary: testSettingsMenuItems test failing → Removed "about:home" text in URL bar causing testSettingsMenuItems test fail
Comment on attachment 8666047 [details]
MozReview Request: Bug 1208512 - testSettingsMenuItems test failing; r?mcomella

https://reviewboard.mozilla.org/r/20417/#review18335

This url isn't shown on the screen so there's no good reason to have an assertion here – kill it with fire!
Attachment #8666047 - Flags: review?(michael.l.comella) → review+
Note that this change alone won't get the test to succeed.  Bug 1208523 is tracking another
https://hg.mozilla.org/integration/fx-team/rev/90e35958c8d67eeceba4963fcfc1cd035146e365
Bug 1208512 - Removed about:home text in URL bar causing testSettingsMenuItems test fail; r=mcomella
https://hg.mozilla.org/mozilla-central/rev/90e35958c8d6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.