1208512 - Removed "about:home" text in URL bar causing testSettingsMenuItems test fail

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

In bug 1038996 the page title for about:home was removed.  This is breaking some tests but hasn't been picked up on try because our test settings disable the test on the two platforms that we can test on in try!  

Test config are:

[testSettingsMenuItems.java]
# disabled on Android 2.3, bug 979552; on 4.3, bug 1144898
skip-if = android_version == "10" || android_version == "18"

We should fix this test

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1208512 - testSettingsMenuItems test failing; r?mcomella

Bug 1208512 - testSettingsMenuItems test failing; r?mcomella

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8666047 [details]
MozReview Request: Bug 1208512 - testSettingsMenuItems test failing; r?mcomella

https://reviewboard.mozilla.org/r/20417/#review18335

This url isn't shown on the screen so there's no good reason to have an assertion here – kill it with fire!

Comment 3

[Martyn Haigh (:mhaigh)]

Note that this change alone won't get the test to succeed.  Bug 1208523 is tracking another

Comment 4

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/90e35958c8d67eeceba4963fcfc1cd035146e365
Bug 1208512 - Removed about:home text in URL bar causing testSettingsMenuItems test fail; r=mcomella

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/90e35958c8d6