1208544 - Make devtools inspector listen to mutations on pseudo elements with MutationObserver->nativeAnonymousChildList

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Brian Grinstead [:bgrins]]

+++ This bug was initially created as a clone of Bug #1034110 +++

Breaking the devtools-specific work for this project into a separate bug.

Basically, if a style rule is removed that causes the pseudo element to no longer be an anonymous child of the parent, I'd like to know.  Likewise if a new style rule is added.  I've put together a basic test case here: https://bgrins.github.io/devtools-demos/inspector/pseudo.html.

Comment 1

[:Gijs (he/him)]

Brian, will this also fix the testcase from bug 185431 comment 33 ?

Comment 2

[Brian Grinstead [:bgrins]]

(In reply to :Gijs Kruitbosch from comment #1)
> Brian, will this also fix the testcase from bug 185431 comment 33 ?

The platform bits from Bug 1034110 should be reusable in DOMi if it's using a MutationObserver.  Then it would need to add nativeAnonymousChildList to the MutationObserverInit options, and treat that mutation similarly to a childList.

Comment 3

[:Gijs (he/him)]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> (In reply to :Gijs Kruitbosch from comment #1)
> > Brian, will this also fix the testcase from bug 185431 comment 33 ?
> 
> The platform bits from Bug 1034110 should be reusable in DOMi if it's using
> a MutationObserver.  Then it would need to add nativeAnonymousChildList to
> the MutationObserverInit options, and treat that mutation similarly to a
> childList.

Right, but the person who posted that testcase *actually* cares about Firefox's devtools Inspector instead of DOMI and just got confused about which bug they wanted... I'm asking if this frontend bit will fix this in inspector.

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to Brian Grinstead [:bgrins] from comment #2)
> > (In reply to :Gijs Kruitbosch from comment #1)
> > > Brian, will this also fix the testcase from bug 185431 comment 33 ?
> > 
> > The platform bits from Bug 1034110 should be reusable in DOMi if it's using
> > a MutationObserver.  Then it would need to add nativeAnonymousChildList to
> > the MutationObserverInit options, and treat that mutation similarly to a
> > childList.
> 
> Right, but the person who posted that testcase *actually* cares about
> Firefox's devtools Inspector instead of DOMI and just got confused about
> which bug they wanted... I'm asking if this frontend bit will fix this in
> inspector.

Ah, yeah this bug is to fix this in the DevTools frontend

Comment 5

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5eafed70a117

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d6b2e070b5d0

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d6b2e070b5d0