120858 - Make nightly mozilla builds talkback-enabled (Mac)

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[J.J. Enser]

For a number of releases now, we have added talkback "by hand" to mozilla
release bits on mac.
I've had this automation enhancement request on my list for a while, but didn't
find a specific bug in bugzilla (other than 94908, which was for 0.9.4).
So here it is, now that I've done the work to implement this.

Patches will follow, and i will need to have them r=/sr=/a= in order to get this
in for 0.9.8.

Comment 1

[J.J. Enser]

Attachment: patches to packages-mac, fullcircle.jst and config.ini_tmpl

fullcircle.xpi should be named talkback.xpi, like windows. Patches include this
change, except that fullcircle.jst will have to be checked in as "talkback.jst"

Comment 2

[J.J. Enser]

Attachment: corresponding changes to the ns tree

Comment 3

[J.J. Enser]

I notice that the mozilla & netscape flavors of fullcircle.jst/talkback.jst
(which become install.js in the corresponding .xpi file) have a different
initInstall() statement:

in mozilla:
     var err = initInstall("Talkback", "/FullCircle/TalkBack", "$Version$");

in ns:
     var err = initInstall("FullCircle Talkback", "FullCircle", "$Version$");

is this ok ? Shouldn't they both use the same syntax?
cc'ing more expert people

Comment 4

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin when this is ready.

Comment 5

[J.J. Enser]

awaiting patches review and an answer on my last question (initInstall syntax)
before checking in the changes.

Comment 6

[Samir Gehani]

JJ, 
I seem to recall that the fullcircle xpi built in the mozilla tree is a dummy
one that is replaced by the one built in the commercial tree which makes the
syntax in the mozilla fullcircle.jst irrelevant.  (In fact, I'm sure because I
looked at the mozilla tree's fullcircle.jst and it doesn't actually install
anything.  Maybe we need a big comment atop the mozilla tree's fullcircle.jst
saying this is a dummy file and explaining how the build system replaces it with
the fullcircle xpi from the commercial tree.)

Comment 7

[J.J. Enser]

Samir, thanks for jumping in, but the whole purpose of this bug and the changes
submitted is to include talkback with mozilla bits, no more "dummy" install!
See the attached patch to fullcircle.jst and you'll see that now it actually
does things, hence the question about the initInstall() syntax which is now
relevant.

Comment 8

[Daniel Veditz [:dveditz]]

The initInstall() arguments should match, and should match XP too. but I don't
see it as a reason to hold up this fix. "Fullcircle" has got to go in any case.

Windows has "Quality Feedback Agent", "Quality Feedback Agent". Linux uses the
same first arg (description) but uses an incorrect absolute registry path
"/Fullcircle/Talkback". An absolute registry name is wrong because talkback is
installed once per mozilla install, not globally on the machine.

I'd go with the way windows has it.

The Mozilla version of talkback.jst has the version string fixed as "6.5.blah"
-- it should be changed to $Version$

Comment 9

[Jon Granrose]

JJ - how does the mozilla build get the Talkback files to package into the
talkback.xpi?  I would think the mozilla build needs to create the stub and blob
with the dummy talkback.xpi file as a place holder and then the netscape build
comes along later and replaces the dummy file and delivers new talkback bits
with the real talkback.xpi file.  That's how we had to do it for win32 and
linux; the only other option was to hold off on delivering the mozilla bits til
after the netscape build was done and we didn't want to hold up the mozilla
delivery.

Comment 10

[Daniel (Leaf) Nunes]

Comment on attachment 65691 [details] [diff] [review]
patches to packages-mac, fullcircle.jst and config.ini_tmpl

r=leaf

Comment 11

[Daniel (Leaf) Nunes]

Comment on attachment 65693 [details] [diff] [review]
corresponding changes to the ns tree

r=leaf

Comment 12

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers)

Comment 13

[J.J. Enser]

note that following dveditz's input, talkback.jst will include:

> var err = initInstall("Quality Feedback Agent", "Quality Feedback Agent",
> "$Version$");

super-review anybody ? or can I land this as soon as the tree opens for approved
bugs today?

Comment 14

[Jon Granrose]

sr=granrose.  let's get this in today if it isn't already.

Comment 15

[J.J. Enser]

patches checked in. marking fixed.

Comment 16

[K'Trina Medina]

Verified on 2002-01-25-03 (comm & moz build) using Mac 9.1

Comment 17

[J.J. Enser]

K'Trina: same comment as in bug 121494: please verify that Talkback is triggered
when crashing using 0.9.8 mozilla build.