Closed Bug 1208602 Opened 9 years ago Closed 9 years ago

Support "Copy URI" to get "about:config?filter=prefname"

Categories

(Toolkit :: Preferences, enhancement)

44 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox44 --- affected

People

(Reporter: yfdyh000, Assigned: yfdyh000)

References

Details

Attachments

(1 file)

Attached patch patch v1Splinter Review
It should be expose instead of hidden.
Attachment #8666160 - Flags: review?(gavin.sharp)
To clarify: you're proposing a "Copy URI" menu item for every pref, that copies a link to about:config, filtered to that pref.

I think "Copy URI" as the title for that would be pretty confusing, particularly since some pref values are also URIs.

I don't personally think this is worth adding (relatively low utility, cost of confusion/complexity), but someone else should make that call.
Attachment #8666160 - Flags: review?(gavin.sharp)
Attachment #8666160 - Flags: review?(dtownsend)
Attachment #8666160 - Flags: feedback-
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #1)
> To clarify: you're proposing a "Copy URI" menu item for every pref, that
> copies a link to about:config, filtered to that pref.
> 
> I think "Copy URI" as the title for that would be pretty confusing,
> particularly since some pref values are also URIs.

I guess the users of about:config context menu can identify that it is a common menu, and I think that this "URI" is accurate term to describe it.


> I don't personally think this is worth adding (relatively low utility, cost
> of confusion/complexity), but someone else should make that call.

I know it is not so common, but the should be added as a supplement to the page and bug 239533. I have considered it to be made into an extension (just an idea, no works), and the automatic recognition of such a link, it may be more useful. But I hope to get feedback and even take over, of course, if the get review+ is good too.
"Copy link to pref" would be a much clearer menuitem label. But I still don't think this is worth adding :)
In fact, I would like to know why this is the form of URI, no linked on Web, the users still need to manually copy and paste it and get a restricted editor :(

We use this URI form in what place? I feel it is a small minority. So I prefer to improve its visibility, since it already exists.
Comment on attachment 8666160 [details] [diff] [review]
patch v1

Review of attachment 8666160 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to YF (Yang) from comment #4)
> In fact, I would like to know why this is the form of URI, no linked on Web,
> the users still need to manually copy and paste it and get a restricted
> editor :(
> 
> We use this URI form in what place? I feel it is a small minority. So I
> prefer to improve its visibility, since it already exists.

We don't use it anywhere, and in fact Gavin didn't think it was very useful back when it was added in bug 239533 either, but at least in that case the code wasn't adding new UI. I'd be inclined to remove it since as you say it really isn't useful but it isn't doing much harm right now. I agree with Gavin though, we shouldn't be adding UI for this either.
Attachment #8666160 - Flags: review?(dtownsend) → review-
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: