1208805 - the background of the menupopup is transparent at "subscribe to..." page

Status: RESOLVED WORKSFORME

(Core :: DOM: Security, defect)

Description

[atlanto]

STR:
1. Open any web site having feeds, https://blog.mozilla.org/ for example.
2. "Subscribe to This Page"
3. "Open in new non-e10s window"
4. Click "Live Bookmarks"
The background of the menupopup is transparent like 'background-color: transparent' or '-moz-appearance: none'.

The result of mozregression --good 2015-09-15 --bad 2015-09-16
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c2d2b0c046a3673aa4937a921a026c8b6b3ea04a&tochange=92ba84502c367b5f8f81f59168f1bc43e26b24c2
So maybe this issue is caused by bug 1195162, I guess.

(though I don't know whether this "subscribe to..." page is being maintained, because of bug 1109714)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Kamil, Matt, I think that one got fixed, can you take a look?

Comment 2

[Kamil Jozwiak [:kjozwiak]]

Attachment: issue.png

I used the following build but I couldn't reproduce the original issue:
* https://archive.mozilla.org/pub/firefox/nightly/2015/09/2015-09-26-03-02-16-mozilla-central/

I used the steps that were provided in comment #0 but I couldn't reproduce the original problem. Once you've selected "Subscribe to This Page..." the "Subscribe Now" button isn't working under e10s in that particular build (fx44 m-c). I tried going through the same process via non-e10s but I couldn't reproduce the problem. I'm not really sure what I'm looking for without any visual comparison.

I went through the following builds and followed the STR from comment #0 and ensured that I didn't see any similar issues being described by the original reporter:
* https://archive.mozilla.org/pub/firefox/nightly/2016/03/2016-03-15-03-02-30-mozilla-central/
* https://archive.mozilla.org/pub/firefox/nightly/2016/03/2016-03-15-00-40-19-mozilla-aurora/
* https://archive.mozilla.org/pub/firefox/candidates/46.0b1-candidates/build8/
* https://archive.mozilla.org/pub/firefox/releases/45.0/

Results for OSX 10.11.3:

I went through fx48.0a1, fx47.0a2, fx46.0b1 and fx45.0 and it seems like all the "Live Bookmark" windows seem to be somewhat transparent.. I assume this is the correct behaviour? Attached an image for clarification.

Possible issues:

Issue #1:

It seems like the "Subscribe to This Page..." button isn't appearing under the bookmark menu for x48.0a and fx47.0a2. To add a "Live Feed", you'll need to physically visit the feed, example https://planet.mozilla.org/atom.xml and click on "Subscribe" from there. With the older m-c branch that I've listed above, when you visit either https://planet.mozilla.org/ or https://blog.mozilla.org/, you would see a "Subscribe to This Page..." button under the bookmark menu. This doesn't affect fx46.0b1 and fx45.0 so this might be related to e10s.

Chris, I couldn't reproduce the original issue and wasn't really sure what I was looking for without a screenshot or any visual representation of the original problem. I went through fx48.0a1, fx47.0a2, fx46.0b1 and fx45.0 and the transparency for live bookmarking looked the same throughout each of those builds. The one thing I did find was that "Subscribe to This Page..." is missing from the bookmark menu under fx48.0a1, fx47.0a2. Not sure if this was removed because of the e10s work.

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Kamil Jozwiak [:kjozwiak] from comment #2)
> Chris, I couldn't reproduce the original issue and wasn't really sure what I
> was looking for without a screenshot or any visual representation of the
> original problem. I went through fx48.0a1, fx47.0a2, fx46.0b1 and fx45.0 and
> the transparency for live bookmarking looked the same throughout each of
> those builds. The one thing I did find was that "Subscribe to This Page..."
> is missing from the bookmark menu under fx48.0a1, fx47.0a2. Not sure if this
> was removed because of the e10s work.

Thanks Kamil.

:atlanto, can you still reproduce that problem? If so, could you paste a screenshot of the problem? Thanks!

Comment 4

[atlanto]

Thanks for your effort.
This is reproducible with https://archive.mozilla.org/pub/firefox/nightly/2015/09/2015-09-16-03-02-03-mozilla-central/firefox-43.0a1.en-US.win64.zip
However, probably since bug 1109714 was resolved, this is no longer reproducible. 45.0 does not have this issue.

>It seems like the "Subscribe to This Page..." button isn't appearing under the bookmark menu for x48.0a and fx47.0a2.
It was removed with bug 985659 fixed, but main menu Bookmarks has it even now.

>it seems like all the "Live Bookmark" windows seem to be somewhat transparent..
It is not transparent on Windows, but it is another story anyway.

Comment 5

[atlanto]

Attachment: FWIW, old issue what I saw.

Comment 6

[atlanto]

Attachment: FWIW, bookmarks toolbar what I see.

Comment 7

[Christoph Kerschbaumer [:ckerschb]]

(In reply to atlanto from comment #4)
> However, probably since bug 1109714 was resolved, this is no longer
> reproducible. 45.0 does not have this issue.

Thanks everyone for your input. I think it's safe to mark this one as fixed as well.