Closed Bug 1208863 Opened 6 years ago Closed 6 years ago

Highlights around active tab is uneven on the right and bottom of tab

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

43 Branch
defect
Not set
normal

Tracking

(firefox44 verified, fennecNightly+)

VERIFIED FIXED
Firefox 44
Tracking Status
firefox44 --- verified
fennec Nightly+ ---

People

(Reporter: jonalmeida, Assigned: sebastian)

References

Details

Attachments

(2 files)

Attached image Screenshot_of_issue.png
STR:
- Open Nightly, and make sure there are no open tabs in the tabs tray
- Browse to google.com and enter a search term
- Press the search button and before the page loads, tap on the tabs tray icon
- Observe that the as the tab icon updates, the active tab highlight has thicker edges on the right and bottom of the tab. (See attached screenshot)

Current Nightly version: 43.0a1 (2015-09-21)
tracking-fennec: --- → ?
Blocks: tabs-tray
tracking-fennec: ? → Nightly+
Assignee: nobody → s.kaspari
This seems to be only happening in TabsGridLayout and never in TabsListLayout.
Something with the ScaleType and Matrix in TabsPanelThumbnailView / CropImageView is going wrong. It does not seem to happen if I always use ScaleType.FIT_XY.
(In reply to Sebastian Kaspari (:sebastian) from comment #2)
> Something with the ScaleType and Matrix in TabsPanelThumbnailView /
> CropImageView is going wrong. It does not seem to happen if I always use
> ScaleType.FIT_XY.

If this is the case, perhaps it has something to do with the timing of when we swap our matrix references, or the process itself:
  https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/widget/CropImageView.java?rev=f4b8d637f2d7#99

If it's unclear what's going on there, it's basically:
  Object first = ..., next = ..., temp = ...;
  temp = first;
  first = next;
  next = temp;

With member variables, as to avoid unnecessary allocation. If it was unclear, perhaps you could update the comments to make it more clear.
(In reply to Michael Comella (:mcomella) from comment #3)
> (In reply to Sebastian Kaspari (:sebastian) from comment #2)
> > Something with the ScaleType and Matrix in TabsPanelThumbnailView /
> > CropImageView is going wrong. It does not seem to happen if I always use
> > ScaleType.FIT_XY.
> 
> If this is the case, perhaps it has something to do with the timing of when
> we swap our matrix references, or the process itself:

Indeed it is. Resetting the matrix, before reusing it, fixes the issue. Thanks for the hint!
Bug 1208863 - CropImageView: Reset matrix before reusing it. r?margaret
Attachment #8678249 - Flags: review?(margaret.leibovic)
Comment on attachment 8678249 [details]
MozReview Request: Bug 1208863 - CropImageView: Reset matrix before reusing it. r?margaret

https://reviewboard.mozilla.org/r/23145/#review20631
Attachment #8678249 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/746279c34dcb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Reproduce the issue on Firefox for Android 44.0a1 (2015-09-27) using Prestigio PSP5508 (Android 4.4.2).
Verified as fixed on latest Nightly Firefox for Android 44.0a1 (2015-10-27).
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.