1208863 - Highlights around active tab is uneven on the right and bottom of tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Jonathan Almeida [:jonalmeida]]

Attachment: Screenshot_of_issue.png

STR:
- Open Nightly, and make sure there are no open tabs in the tabs tray
- Browse to google.com and enter a search term
- Press the search button and before the page loads, tap on the tabs tray icon
- Observe that the as the tab icon updates, the active tab highlight has thicker edges on the right and bottom of the tab. (See attached screenshot)

Current Nightly version: 43.0a1 (2015-09-21)

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

This seems to be only happening in TabsGridLayout and never in TabsListLayout.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Something with the ScaleType and Matrix in TabsPanelThumbnailView / CropImageView is going wrong. It does not seem to happen if I always use ScaleType.FIT_XY.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Sebastian Kaspari (:sebastian) from comment #2)
> Something with the ScaleType and Matrix in TabsPanelThumbnailView /
> CropImageView is going wrong. It does not seem to happen if I always use
> ScaleType.FIT_XY.

If this is the case, perhaps it has something to do with the timing of when we swap our matrix references, or the process itself:
  https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/widget/CropImageView.java?rev=f4b8d637f2d7#99

If it's unclear what's going on there, it's basically:
  Object first = ..., next = ..., temp = ...;
  temp = first;
  first = next;
  next = temp;

With member variables, as to avoid unnecessary allocation. If it was unclear, perhaps you could update the comments to make it more clear.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Michael Comella (:mcomella) from comment #3)
> (In reply to Sebastian Kaspari (:sebastian) from comment #2)
> > Something with the ScaleType and Matrix in TabsPanelThumbnailView /
> > CropImageView is going wrong. It does not seem to happen if I always use
> > ScaleType.FIT_XY.
> 
> If this is the case, perhaps it has something to do with the timing of when
> we swap our matrix references, or the process itself:

Indeed it is. Resetting the matrix, before reusing it, fixes the issue. Thanks for the hint!

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1208863 - CropImageView: Reset matrix before reusing it. r?margaret

Bug 1208863 - CropImageView: Reset matrix before reusing it. r?margaret

Comment 6

[:Margaret Leibovic]

Comment on attachment 8678249 [details]
MozReview Request: Bug 1208863 - CropImageView: Reset matrix before reusing it. r?margaret

https://reviewboard.mozilla.org/r/23145/#review20631

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/746279c34dcbb590100483c7c14dfc06b410d869
Bug 1208863 - CropImageView: Reset matrix before reusing it. r=margaret

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/746279c34dcb

Comment 9

[Teodora Vermesan (:TeoVermesan)]

Reproduce the issue on Firefox for Android 44.0a1 (2015-09-27) using Prestigio PSP5508 (Android 4.4.2).
Verified as fixed on latest Nightly Firefox for Android 44.0a1 (2015-10-27).