1208885 - Use mozGenericWordUtils in mozSpellI18NManager::GetUtil() if the input language is not English

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[(no longer active)]

Found by Viva64.

Comment 1

[(no longer active)]

Attachment: Use mozGenericWordUtils in mozSpellI18NManager::GetUtil() if the input language is not English

Found by Viva64.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8666501 [details] [diff] [review]
Use mozGenericWordUtils in mozSpellI18NManager::GetUtil() if the input language is not English

Did you actually test the change? Since mozGenericWordUtils is currently totally unused and the methods just return NS_ERROR_NOT_IMPLEMENTED.

GetUtil is apparently called only with "" as language (at least in Firefox, dunno about TB)
I'm rather worried that http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/src/mozSpellChecker.cpp#84 will break.

r-, but if you think we really should do the change, please explain what kind of behavior we get.


this is old code https://bugzilla.mozilla.org/show_bug.cgi?id=56301#c214

Comment 3

[(no longer active)]

You're right.

Let me silence the static analysis for now.  I guess nobody has objected yet.  We should remove mozGenericWordUtils since it really has no value!

Comment 4

[(no longer active)]

Attachment: Remove mozGenericWordUtils

Found by Viva64.  In the future we need to add support for more
langauges, but right now mozGenericWordUtils doesn't provide any value.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b2a83e470d01

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b2a83e470d01