1208889 - Migrate mozL10n.DateTimeFormat to Intl API in Email

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

There are two places in Email where we use deprecated mozIntl.DateTimeFormat.

I'm aiming to remove l10n_date overall in this cycle, so I'd like to move them to mozIntl.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8666507 [details] [review]
pull request

Ok, I think it's ready for review. It's part of an attempt to get rid of l10n_date in 2.5 and migrate everything to Intl or mozIntl APIs.

Should be painless :)

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8666507 [details] [review]
pull request

A quick pass suggests it's all good, but especially since this touches app startup, James is the best/most appropriate reviewer.

Comment 4

[James Burke [:jrburke]]

Comment on attachment 8666507 [details] [review]
pull request

Review comments in pull request, please flip review back to me when you want me to do another review pass.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8666507 [details] [review]
pull request

Ok, let me know what you think!

I added a new method to our private mozIntl._gaia.RelativeDate which formats elements.

I also applied your patch except of not adding moz_intl as a dependency on l10n, since it is not required.

Let me know what you think!

Comment 6

[James Burke [:jrburke]]

Comment on attachment 8666507 [details] [review]
pull request

Great to have a non-async way to set the relative time. I left some comments and a diff in the pull request, feel free to flip review back when ready. If no other substantive changes from the diff, then I expect it will be a quick final review.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8666507 [details] [review]
pull request

Sweet!

I may want to squeeze a couple tests in this patch for mozIntl._gaia.formatElement, but your part is ready for r?

(I also got ircal* f+ from :stas on mozIntl changes).

*) that's IRC equivalent of verbal

Comment 8

[James Burke [:jrburke]]

Comment on attachment 8666507 [details] [review]
pull request

r+ with just one nit in the pull request around the number of RelativeDate calls. Thanks for upgrading the email app!

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thanks James!

Commit: https://github.com/mozilla-b2g/gaia/commit/620af8c819fc71112008ba5d99a5163e0ecff7f2