Replace the uses of memset to clean up data in GMPLoader::Load with an inline memset

RESOLVED FIXED in Firefox 44

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ehsan, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
This is found by Viva64.  Because the data we're memsetting to 0
may not be used after this point, the compiler can eliminate the
memsets.  We need to roll our own inline memset that cannot be
optimized away.
(Reporter)

Comment 1

3 years ago
Created attachment 8666511 [details] [diff] [review]
Replace the uses of memset to clean up data in GMPLoader::Load with an inline memset
Attachment #8666511 - Flags: review?(cpearce)
Comment on attachment 8666511 [details] [diff] [review]
Replace the uses of memset to clean up data in GMPLoader::Load with an inline memset

Review of attachment 8666511 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!
Attachment #8666511 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/b04c848c44af
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Blocks: 710966
You need to log in before you can comment on or make changes to this bug.