Closed
Bug 1208892
Opened 9 years ago
Closed 9 years ago
Replace the uses of memset to clean up data in GMPLoader::Load with an inline memset
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: ehsan.akhgari, Unassigned)
References
Details
Attachments
(1 file)
2.41 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
This is found by Viva64. Because the data we're memsetting to 0 may not be used after this point, the compiler can eliminate the memsets. We need to roll our own inline memset that cannot be optimized away.
Reporter | ||
Comment 1•9 years ago
|
||
Attachment #8666511 -
Flags: review?(cpearce)
Comment 2•9 years ago
|
||
Comment on attachment 8666511 [details] [diff] [review] Replace the uses of memset to clean up data in GMPLoader::Load with an inline memset Review of attachment 8666511 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch!
Attachment #8666511 -
Flags: review?(cpearce) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b04c848c44af
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•