Closed
Bug 1208929
Opened 9 years ago
Closed 9 years ago
Enable -Wshadow for /dom/animation
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: birtles, Assigned: birtles)
References
Details
Attachments
(1 file)
|
898 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
I suppose bug 1207030 didn't do this because of the shadowing that will be fixed in bug 1208385.
|
Assignee | |
Comment 1•9 years ago
|
||
This patch also shuffles the order of LOCAL_INCLUDES and FINAL_LIBRARY to match
what most other moz.build files seem to do.
Attachment #8666548 -
Flags: review?(mh+mozilla)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
(In reply to Brian Birtles (:birtles) from comment #0)
> I suppose bug 1207030 didn't do this because of the shadowing that will be
> fixed in bug 1208385.
That should be bug 1207951.
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8666548 [details] [diff] [review]
Turn on -Wshadow for dom/animation
Review of attachment 8666548 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/animation/moz.build
@@ +33,5 @@
> LOCAL_INCLUDES += [
> '/dom/base',
> ]
> +
> +FINAL_LIBRARY = 'xul'
No real need to move this.
Attachment #8666548 -
Flags: review?(mh+mozilla) → review+
|
||
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•