Closed
Bug 1208932
Opened 9 years ago
Closed 9 years ago
Remove ReadMetadataFailureReason::WAITING_FOR_RESOURCES
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(1 file)
After bug 1208931 is landed, ReadMetadataFailureReason::WAITING_FOR_RESOURCES is not used anymore.
|
Assignee | |
Comment 1•9 years ago
|
||
Bug 1208932 - Remove ReadMetadataFailureReason::WAITING_FOR_RESOURCES.
Attachment #8667681 -
Flags: review?(jyavenard)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8667681 [details] MozReview Request: Bug 1208932 - Remove ReadMetadataFailureReason::WAITING_FOR_RESOURCES. https://reviewboard.mozilla.org/r/20811/#review18707 could change the resolution type to just by nsresult; would prevent the long enum name.
Attachment #8667681 -
Flags: review?(jyavenard) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Thanks for the review. One problem with nsresult is it is not extensible when we want to add a custom error code. I think we can just completely remove ReadMetadataFailureReason which has only one field now. If we need to report different types of failures, we can add it back again. However, I don't see the need in the near future.
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5aecd8e89475
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•