1208945 - Rename Color::{To,From}ARGB() so they aren't easily confused with {To,From}ABGR()

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nicholas Nethercote [inactive]]

(Spun off from bug 1208283.)

Color::{To,From}ARGB() are really similar names to Color::{To,From}ABGR().
While refactoring I was scared I would type the wrong one. So I suggest giving
the latter pair, which are uncommon, a different name.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Rename Color::{To,From}ARGB() so they aren't easily confused with {To,From}ABGR()

Comment 2

[Jonathan Watt [:jwatt]]

Maybe "RarelyUsed" instead of uncommon? Or perhaps better, mention that this is to do with endianness with something like {To,From}ABGRForBigEndian(). If the appropriate endianness defines were available it might even be better to ifdef out these functions for little endian platforms.

Comment 3

[Nicholas Nethercote [inactive]]

As long as the name is significantly different to {To,From}ARGB() I don't mind what it is. I'm happy to let Bas bikeshed it in his review.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/feda11b57723

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/feda11b57723