1208973 - Intermittent test_basic_pan.html | application crashed [@ mozalloc_abort]

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Comment 1

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=14785045
repository: mozilla-inbound
start_time: 2015-09-27T22:04:48
who: nigelbabu[at]gmail[dot]com
machine: tst-linux64-spot-697
buildname: b2g_emulator_vm mozilla-inbound debug test mochitest-debug-21
revision: 005e98e2c5c9

[Child 859] ###!!! ABORT: file /builds/slave/b2g_m-in_emu-d_dep-00000000000/build/gecko/ipc/chromium/src/base/pickle.cc, line 201
PROCESS-CRASH | gfx/layers/apz/test/mochitest/test_basic_pan.html | application crashed [@ mozalloc_abort]
No tests run or test summary not found
09-28 05:48:25.044 I/Gecko   (  859): [Child 859] ###!!! ABORT: file /builds/slave/b2g_m-in_emu-d_dep-00000000000/build/gecko/ipc/chromium/src/base/pickle.cc, line 201
09-28 05:48:25.194 E/Gecko   (  859): mozalloc_abort: [Child 859] ###!!! ABORT: file /builds/slave/b2g_m-in_emu-d_dep-00000000000/build/gecko/ipc/chromium/src/base/pickle.cc, line 201
Return code: 1

Comment 2

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=14849195
repository: mozilla-inbound
start_time: 2015-09-28T18:00:46
who: philringnalda[at]gmail[dot]com
machine: tst-linux64-spot-629
buildname: b2g_emulator_vm mozilla-inbound opt test mochitest-8
revision: c6142b815de0

[Child 853] ###!!! ABORT: Aborting on channel error.: file /builds/slave/b2g_m-in_emu_dep-0000000000000/build/gecko/ipc/glue/MessageChannel.cpp, line 1768
PROCESS-CRASH | gfx/layers/apz/test/mochitest/test_basic_pan.html | application crashed [@ memcpy + 0x194]
No tests run or test summary not found
09-29 01:48:29.593 I/Gecko   (  853): [Child 853] ###!!! ABORT: Aborting on channel error.: file /builds/slave/b2g_m-in_emu_dep-0000000000000/build/gecko/ipc/glue/MessageChannel.cpp, line 1768
09-29 01:48:29.593 E/Gecko   (  853): mozalloc_abort: [Child 853] ###!!! ABORT: Aborting on channel error.: file /builds/slave/b2g_m-in_emu_dep-0000000000000/build/gecko/ipc/glue/MessageChannel.cpp, line 1768
09-29 01:48:29.654 F/libc    (  853): Fatal signal 11 (SIGSEGV) at 0x00000000 (code=1)
This usually indicates the B2G process has crashed
Return code: 1

Comment 4

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=2320175
repository: mozilla-central
start_time: 2015-09-29T16:28:49
who: philringnalda[at]gmail[dot]com
machine: tst-linux64-spot-1821
buildname: b2g_emulator_vm mozilla-central debug test mochitest-debug-21
revision: ccee6614fd9d

[Child 871] ###!!! ABORT: file /builds/slave/b2g_m-cen_emu-d_ntly-000000000/build/gecko/ipc/chromium/src/base/pickle.cc, line 201
PROCESS-CRASH | gfx/layers/apz/test/mochitest/test_basic_pan.html | application crashed [@ mozalloc_abort]
No tests run or test summary not found
09-30 00:30:37.722 I/Gecko   (  871): [Child 871] ###!!! ABORT: file /builds/slave/b2g_m-cen_emu-d_ntly-000000000/build/gecko/ipc/chromium/src/base/pickle.cc, line 201
09-30 00:30:38.043 E/Gecko   (  871): mozalloc_abort: [Child 871] ###!!! ABORT: file /builds/slave/b2g_m-cen_emu-d_ntly-000000000/build/gecko/ipc/chromium/src/base/pickle.cc, line 201
Return code: 1

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: MozReview Request: Bug 1208973 - Refactor and add logging to TaskThrottler. r=

Bug 1208973 - Refactor and add logging to TaskThrottler. r=

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: MozReview Request: Bug 1208973 - Move function bodies into .cpp file, and remove an unused one. r=

Bug 1208973 - Move function bodies into .cpp file, and remove an unused one. r=

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: MozReview Request: Bug 1208973 - Ensure all code in TaskThrottler is threadsafe since it gets called from various threads. r=

Bug 1208973 - Ensure all code in TaskThrottler is threadsafe since it gets called from various threads. r=

Hat tip to :froydnj for describing the proof-of-lock technique used in this patch
in his blog at https://blog.mozilla.org/nfroyd/2015/09/17/compiler-enforced-locked-accesses/

Comment 8

[Botond Ballo [:botond]]

Comment on attachment 8669380 [details]
MozReview Request: Bug 1208973 - Refactor and add logging to TaskThrottler. r=

https://reviewboard.mozilla.org/r/21199/#review19153

Comment 9

[Botond Ballo [:botond]]

Comment on attachment 8669381 [details]
MozReview Request: Bug 1208973 - Move function bodies into .cpp file, and remove an unused one. r=

https://reviewboard.mozilla.org/r/21201/#review19155

Comment 10

[Botond Ballo [:botond]]

Comment on attachment 8669382 [details]
MozReview Request: Bug 1208973 - Ensure all code in TaskThrottler is threadsafe since it gets called from various threads. r=

https://reviewboard.mozilla.org/r/21203/#review19159

I like the proof-of-lock technique, thanks for bringing it to my attention!

::: gfx/layers/apz/src/TaskThrottler.h:15
(Diff revision 1)
>  #include "mozilla/UniquePtr.h"          // for UniquePtr

#include "mozilla/Monitor.h"

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3218e220831
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca9e202ceb12
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbe92d963519

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c3218e220831
https://hg.mozilla.org/mozilla-central/rev/ca9e202ceb12
https://hg.mozilla.org/mozilla-central/rev/dbe92d963519