Intermittent test_basic_pan.html | application crashed [@ mozalloc_abort]

RESOLVED FIXED in Firefox 44

Status

()

Core
Panning and Zooming
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nigelb, Assigned: kats)

Tracking

({intermittent-failure})

unspecified
mozilla44
intermittent-failure
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox44 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

Comment hidden (empty)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Duplicate of this bug: 1209444
Comment hidden (Treeherder Robot)
Depends on: 1210465
Created attachment 8669380 [details]
MozReview Request: Bug 1208973 - Refactor and add logging to TaskThrottler. r=

Bug 1208973 - Refactor and add logging to TaskThrottler. r=
Attachment #8669380 - Flags: review?(botond)
Created attachment 8669381 [details]
MozReview Request: Bug 1208973 - Move function bodies into .cpp file, and remove an unused one. r=

Bug 1208973 - Move function bodies into .cpp file, and remove an unused one. r=
Attachment #8669381 - Flags: review?(botond)
Created attachment 8669382 [details]
MozReview Request: Bug 1208973 - Ensure all code in TaskThrottler is threadsafe since it gets called from various threads. r=

Bug 1208973 - Ensure all code in TaskThrottler is threadsafe since it gets called from various threads. r=

Hat tip to :froydnj for describing the proof-of-lock technique used in this patch
in his blog at https://blog.mozilla.org/nfroyd/2015/09/17/compiler-enforced-locked-accesses/
Attachment #8669382 - Flags: review?(botond)
Assignee: nobody → bugmail.mozilla
Blocks: 1209444

Updated

3 years ago
Attachment #8669380 - Flags: review?(botond) → review+
Comment on attachment 8669380 [details]
MozReview Request: Bug 1208973 - Refactor and add logging to TaskThrottler. r=

https://reviewboard.mozilla.org/r/21199/#review19153
Comment on attachment 8669381 [details]
MozReview Request: Bug 1208973 - Move function bodies into .cpp file, and remove an unused one. r=

https://reviewboard.mozilla.org/r/21201/#review19155
Attachment #8669381 - Flags: review?(botond) → review+
Comment on attachment 8669382 [details]
MozReview Request: Bug 1208973 - Ensure all code in TaskThrottler is threadsafe since it gets called from various threads. r=

https://reviewboard.mozilla.org/r/21203/#review19159

I like the proof-of-lock technique, thanks for bringing it to my attention!

::: gfx/layers/apz/src/TaskThrottler.h:15
(Diff revision 1)
>  #include "mozilla/UniquePtr.h"          // for UniquePtr

#include "mozilla/Monitor.h"
Attachment #8669382 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/c3218e220831
https://hg.mozilla.org/mozilla-central/rev/ca9e202ceb12
https://hg.mozilla.org/mozilla-central/rev/dbe92d963519
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Duplicate of this bug: 1209444
You need to log in before you can comment on or make changes to this bug.