Closed
Bug 1209029
Opened 9 years ago
Closed 9 years ago
.settings-menu .icon classes are obsolete and should be removed
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox44 fixed)
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [tech-debt])
Attachments
(1 file)
|
72.52 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
In reviewing a patch, I noticed we have a set of ".settings-menu .icon" classes in panel.css. Since bug 1183618 these are no longer used and should be removed.
Additionally, we should check to see if we can remove the associated svg files.
|
Assignee | |
Comment 1•9 years ago
|
||
Lets just do this ;-)
glyph-help-16x16.svg is still used so we can't remove that yet.
Attachment #8667904 -
Flags: review?(mdeboer)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → standard8
Iteration: --- → 44.1 - Oct 5
Points: --- → 1
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8667904 [details] [diff] [review]
.settings-menu .icon classes in Loop's panel are obsolete and should be removed.
Review of attachment 8667904 [details] [diff] [review]:
-----------------------------------------------------------------
w00t!
Attachment #8667904 -
Flags: review?(mdeboer) → review+
|
||
Comment 4•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•