Put "set a home page" pref behind a Nightly flag

RESOLVED FIXED in Firefox 43

Status

()

Firefox for Android
Settings and Preferences
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

35 Branch
Firefox 44
Points:
---

Firefox Tracking Flags

(firefox43 fixed, firefox44 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We're still working on the "set a home page" UX, but it's currently on Aurora. Let's put it behind a Nightly flag until it's ready to ship.
(Assignee)

Comment 1

2 years ago
Created attachment 8666856 [details]
MozReview Request: Bug 1209032 - Put "set a home page" pref behind a Nightly flag. r=mhaigh

Bug 1209032 - Put "set a home page" pref behind a Nightly flag. r=mhaigh
Attachment #8666856 - Flags: review?(mhaigh)
(Assignee)

Comment 2

2 years ago
Comment on attachment 8666856 [details]
MozReview Request: Bug 1209032 - Put "set a home page" pref behind a Nightly flag. r=mhaigh

Bug 1209032 - Put "set a home page" pref behind a Nightly flag. r=mhaigh
(Assignee)

Comment 3

2 years ago
One issue with uplifting this is that aurora users who have set a home page won't have any way to un-set it... maybe I should also add a NIGHTLY_BUILD check around the homepage pref check in BrowserApp.
Comment on attachment 8666856 [details]
MozReview Request: Bug 1209032 - Put "set a home page" pref behind a Nightly flag. r=mhaigh

https://reviewboard.mozilla.org/r/20607/#review18717

Looking good!
Attachment #8666856 - Flags: review?(mhaigh) → review+
(Assignee)

Comment 5

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/9f0c016e855bfa1eddcd849df478a48a496c778d
Bug 1209032 - Put "set a home page" pref behind a Nightly flag. r=mhaigh
(Assignee)

Comment 6

2 years ago
Comment on attachment 8666856 [details]
MozReview Request: Bug 1209032 - Put "set a home page" pref behind a Nightly flag. r=mhaigh

Approval Request Comment
[Feature/regressing bug #]: bug 1195721
[User impact if declined]: "set a home page" feature will ship before it's ready
[Describe test coverage new/current, TreeHerder]: no automated tests
[Risks and why]: low-risk, disabled a feature
[String/UUID change made/needed]: none
Attachment #8666856 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/9f0c016e855b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8666856 [details]
MozReview Request: Bug 1209032 - Put "set a home page" pref behind a Nightly flag. r=mhaigh

Let's uplift this to aurora so we don't accidentally ship in 43 beta.
Attachment #8666856 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/5ca76d2f53b6
status-firefox43: --- → fixed
You need to log in before you can comment on or make changes to this bug.