1209091 - Re-enable signature checking for add-ons which was accidentally disabled

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect, P1)

Description

[Christiane Ruetten [INACTIVE]]

https://hg.mozilla.org/mozilla-central/diff/4e5e7b50bc48/dom/apps/UserCustomizations.jsm#l1.49 accidentally disabled signature checking for add-ons by setting "AppsUtils.allowUnsignedAddons = true;". This has to go asap.

Comment 1

[Christiane Ruetten [INACTIVE]]

Attachment: Disable add-on signature workaround

Comment 2

[Christiane Ruetten [INACTIVE]]

[Blocking Requested - why for this release]:

On September 15th, a patch landed on master that accidentally introduced development code that disabled signature checking for add-ons. We can't ship anything without this critical security requirement.

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 8666741 [details] [diff] [review]
Disable add-on signature workaround

Review of attachment 8666741 [details] [diff] [review]:
-----------------------------------------------------------------

/me ducks

Comment 4

[Mahendra Potharaju [:mahe]]

Blocks 2.5 with P1 as its sec-critical

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b4bedf4f6bb

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

This was introduced in bug 1198970 for 43. Do we want to allow addon signing to be disabled by the user in 43 (aurora or otherwise?)  If not, then this may need uplift to aurora.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4b4bedf4f6bb

Comment 8

[Christiane Ruetten [INACTIVE]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #6)
> This was introduced in bug 1198970 for 43. Do we want to allow addon signing
> to be disabled by the user in 43 (aurora or otherwise?)  If not, then this
> may need uplift to aurora.

You're right, this made it into FIREFOX_AURORA_43_BASE. That code was definitely not supposed to be there. Will create a patch against 43.

Comment 9

[Christiane Ruetten [INACTIVE]]

Liz, I haven't worked on any uplift patch for mozilla-central so far, and the patching/landing docs are strangely useless. If I repeat the modification on top of FIREFOX_AURORA_43_BASE, hg qnew pushes the exact same patch onto the queue that is already in attachement 8666741. Seems wasteful to run all the processes again. How does uplifting work in this trivial case?

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

May be a better question for the sheriffs. But, if this applies fine to aurora, I don't see why you would need to create a new patch. We can uplift the existing one. Which docs are you looking at?

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Wes can you help out here?

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8666741 [details] [diff] [review]
Disable add-on signature workaround

4b4bedf4f6bb uplifts cleanly to aurora. I'd say we just need an a+ from someone like you, Liz. :)

Approval Request Comment
[Feature/regressing bug #]: Bug 1198970 
[User impact if declined]: Unsigned addons will install when they shouldn't.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]: None.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8666741 [details] [diff] [review]
Disable add-on signature workaround

OK to uplift to aurora. Turning addon signing back on!

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1389a10c4542

Comment 15

[Christiane Ruetten [INACTIVE]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #10)
> Which docs are you looking at?

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch and https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F which is linked from the first one.