Closed
Bug 1209174
Opened 9 years ago
Closed 9 years ago
Fix a conditional statement in nsMsgDBView.cpp for not junk / junk batch notifications to gloda
Categories
(MailNews Core :: Database, defect)
MailNews Core
Database
Tracking
(thunderbird44 fixed, thunderbird_esr38 affected)
RESOLVED
FIXED
Thunderbird 44.0
People
(Reporter: ssitter, Assigned: ssitter)
References
Details
(Whiteboard: [pvs-studio])
Attachments
(1 file)
|
1.29 KB,
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
From http://www.viva64.com/en/b/0347/
PVS-Studio's diagnostic message: V547 Expression is always false. Probably the '||' operator should be used here. mailnews/base/src/nsMsgDBView.cpp 3014
nsresult nsMsgDBView::
ApplyCommandToIndices(nsMsgViewCommandTypeValue command, ....)
{
....
if ((command == nsMsgViewCommandType::junk) &&
(command == nsMsgViewCommandType::unjunk))
....
}
|
Assignee | |
Comment 1•9 years ago
|
||
|
||
Updated•9 years ago
|
Attachment #8666861 -
Flags: review?(Pidgeot18) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/2c1191c81f3885c2fa605a5e8eebf0be3c40192c
Bug 1209174 - Fix a conditional statement in nsMsgDBView.cpp. r=jcranmer
|
|
||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 44.0
|
||
Comment 4•9 years ago
|
||
I doubt this should have status-firefox44=affected :)
Blocks: 465618
status-firefox44:
affected → ---
status-thunderbird44:
--- → fixed
status-thunderbird_esr38:
--- → affected
Summary: Fix a conditional statement in nsMsgDBView.cpp → Fix a conditional statement in nsMsgDBView.cpp for not junk / junk batch notifications to gloda
You need to log in
before you can comment on or make changes to this bug.
Description
•