Fix a conditional statement in nsMsgDBView.cpp for not junk / junk batch notifications to gloda

RESOLVED FIXED in Thunderbird 44.0

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ssitter, Assigned: ssitter)

Tracking

Trunk
Thunderbird 44.0

Thunderbird Tracking Flags

(thunderbird44 fixed, thunderbird_esr38 affected)

Details

(Whiteboard: [pvs-studio])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
From http://www.viva64.com/en/b/0347/

PVS-Studio's diagnostic message: V547 Expression is always false. Probably the '||' operator should be used here. mailnews/base/src/nsMsgDBView.cpp 3014

nsresult nsMsgDBView::
ApplyCommandToIndices(nsMsgViewCommandTypeValue command, ....)
{
  ....
  if ((command == nsMsgViewCommandType::junk) &&
      (command == nsMsgViewCommandType::unjunk))
  ....
}
(Assignee)

Comment 1

3 years ago
Created attachment 8666861 [details] [diff] [review]
Fix a conditional statement in nsMsgDBView.cpp
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #8666861 - Flags: review?(Pidgeot18)

Comment 2

3 years ago
Nice catch.
Attachment #8666861 - Flags: review?(Pidgeot18) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 3

3 years ago
https://hg.mozilla.org/comm-central/rev/2c1191c81f3885c2fa605a5e8eebf0be3c40192c
Bug 1209174 - Fix a conditional statement in nsMsgDBView.cpp. r=jcranmer

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 44.0

Comment 4

3 years ago
I doubt this should have status-firefox44=affected :)
Blocks: 465618
status-firefox44: affected → ---
status-thunderbird44: --- → fixed
status-thunderbird_esr38: --- → affected
Summary: Fix a conditional statement in nsMsgDBView.cpp → Fix a conditional statement in nsMsgDBView.cpp for not junk / junk batch notifications to gloda
You need to log in before you can comment on or make changes to this bug.