Closed Bug 1209174 Opened 5 years ago Closed 5 years ago

Fix a conditional statement in nsMsgDBView.cpp for not junk / junk batch notifications to gloda

Categories

(MailNews Core :: Database, defect)

defect
Not set
normal

Tracking

(thunderbird44 fixed, thunderbird_esr38 affected)

RESOLVED FIXED
Thunderbird 44.0
Tracking Status
thunderbird44 --- fixed
thunderbird_esr38 --- affected

People

(Reporter: ssitter, Assigned: ssitter)

References

Details

(Whiteboard: [pvs-studio])

Attachments

(1 file)

From http://www.viva64.com/en/b/0347/

PVS-Studio's diagnostic message: V547 Expression is always false. Probably the '||' operator should be used here. mailnews/base/src/nsMsgDBView.cpp 3014

nsresult nsMsgDBView::
ApplyCommandToIndices(nsMsgViewCommandTypeValue command, ....)
{
  ....
  if ((command == nsMsgViewCommandType::junk) &&
      (command == nsMsgViewCommandType::unjunk))
  ....
}
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #8666861 - Flags: review?(Pidgeot18)
Nice catch.
Attachment #8666861 - Flags: review?(Pidgeot18) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/2c1191c81f3885c2fa605a5e8eebf0be3c40192c
Bug 1209174 - Fix a conditional statement in nsMsgDBView.cpp. r=jcranmer
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 44.0
I doubt this should have status-firefox44=affected :)
Blocks: 465618
Summary: Fix a conditional statement in nsMsgDBView.cpp → Fix a conditional statement in nsMsgDBView.cpp for not junk / junk batch notifications to gloda
You need to log in before you can comment on or make changes to this bug.